Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 10804037: Fix up try job reitveld patch. (Closed)

Created:
8 years, 5 months ago by Peter Mayo
Modified:
8 years, 5 months ago
Reviewers:
M-A Ruel
CC:
Roger Tawa OOO till Jul 10th, chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Fix up try job rietveld patch. Switch to os.path.isfile. Correct return code and docstring referencing the type. Add a log message when we are hitting this code. See also http://codereview.chromium.org/10796027/ BUG=None TEST=local presubmit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147560

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M scripts/master/try_job_rietveld.py View 2 chunks +7 lines, -5 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Peter Mayo
8 years, 5 months ago (2012-07-19 22:07:08 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/10804037/diff/1/scripts/master/try_job_rietveld.py File scripts/master/try_job_rietveld.py (right): http://codereview.chromium.org/10804037/diff/1/scripts/master/try_job_rietveld.py#newcode79 scripts/master/try_job_rietveld.py:79: This new line is not 100% necessary. :)
8 years, 5 months ago (2012-07-19 22:47:23 UTC) #2
M-A Ruel
fixed typo in cl description
8 years, 5 months ago (2012-07-19 22:49:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/10804037/1
8 years, 5 months ago (2012-07-19 22:53:39 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 22:55:07 UTC) #5
Change committed as 147560

Powered by Google App Engine
This is Rietveld 408576698