Issue 10804037: Fix up try job reitveld patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10804037: Fix up try job reitveld patch. (Closed)

Created:
8 years, 5 months ago by Peter Mayo

Modified:
8 years, 5 months ago

Reviewers:
M-A Ruel

CC:
Roger Tawa OOO till Jul 10th, chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

More Reviews

Description

Fix up try job rietveld patch. Switch to os.path.isfile. Correct return code and docstring referencing the type. Add a log message when we are hitting this code. See also http://codereview.chromium.org/10796027/ BUG=None TEST=local presubmit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147560

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	scripts/master/try_job_rietveld.py	View		2 chunks	+7 lines, -5 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/10804037/diff/1/scripts/master/try_job_rietveld.py File scripts/master/try_job_rietveld.py (right): http://codereview.chromium.org/10804037/diff/1/scripts/master/try_job_rietveld.py#newcode79 scripts/master/try_job_rietveld.py:79: This new line is not 100% necessary. :)

8 years, 5 months ago (2012-07-19 22:47:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/10804037/1

8 years, 5 months ago (2012-07-19 22:53:39 UTC) #4

Change committed as 147560

Expand Messages | Collapse Messages