Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10804031: Move more files into the content namespace. (Closed)

Created:
8 years, 5 months ago by darin (slow to review)
Modified:
8 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Move more files into the content namespace. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147756

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Total comments: 3

Patch Set 15 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -378 lines) Patch
M base/threading/thread_restrictions.h View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/accelerated_plugin_view_mac.h View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/accelerated_plugin_view_mac.mm View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/async_resource_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store.h View 4 chunks +10 lines, -9 lines 0 comments Download
M content/browser/renderer_host/backing_store.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_aura.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/backing_store_aura.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/backing_store_gtk.h View 3 chunks +8 lines, -5 lines 0 comments Download
M content/browser/renderer_host/backing_store_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.mm View 4 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_manager.h View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/backing_store_manager.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/backing_store_win.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_win.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.h View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 1 4 chunks +8 lines, -7 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/gtk_im_context_wrapper.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +8 lines, -7 lines 0 comments Download
M content/browser/renderer_host/gtk_im_context_wrapper.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/popup_menu_helper_mac.h View 1 2 3 4 2 chunks +9 lines, -8 lines 0 comments Download
M content/browser/renderer_host/popup_menu_helper_mac.mm View 1 2 3 4 2 chunks +9 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 8 chunks +19 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 18 chunks +23 lines, -28 lines 0 comments Download
M content/browser/renderer_host/render_message_filter_win.cc View 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 6 chunks +12 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 6 7 8 7 chunks +13 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 13 chunks +25 lines, -31 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +12 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 3 4 5 6 7 8 9 8 chunks +16 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 5 6 12 chunks +18 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 4 5 6 7 8 9 10 chunks +23 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 7 8 9 9 chunks +12 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +23 lines, -24 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 3 4 5 6 7 8 9 10 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 10 chunks +19 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 13 chunks +27 lines, -30 lines 0 comments Download
M content/browser/renderer_host/test_backing_store.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/test_backing_store.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
8 years, 5 months ago (2012-07-20 23:27:58 UTC) #1
jam
lgtm, thanks http://codereview.chromium.org/10804031/diff/1073/content/browser/renderer_host/backing_store.cc File content/browser/renderer_host/backing_store.cc (right): http://codereview.chromium.org/10804031/diff/1073/content/browser/renderer_host/backing_store.cc#newcode9 content/browser/renderer_host/backing_store.cc:9: BackingStore::BackingStore(content::RenderWidgetHost* widget, nit: get rid of "content::" ...
8 years, 5 months ago (2012-07-20 23:35:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/10804031/14038
8 years, 5 months ago (2012-07-20 23:56:19 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-21 01:30:00 UTC) #4 
Change committed as 147756

Powered by Google App Engine
This is Rietveld 408576698