Chromium Code Reviews| Index: ui/base/dialogs/selected_file_info.h |
| diff --git a/ui/base/dialogs/selected_file_info.h b/ui/base/dialogs/selected_file_info.h |
| index 005de6faecc88e73931ac02d54ded641b5cf70dd..e37d60d16e32332732d60dc832aae71c32836d1a 100644 |
| --- a/ui/base/dialogs/selected_file_info.h |
| +++ b/ui/base/dialogs/selected_file_info.h |
| @@ -15,9 +15,15 @@ namespace ui { |
| // Struct used for passing selected file info to WebKit. |
| struct UI_EXPORT SelectedFileInfo { |
| - // The real path to the selected file. This can be a snapshot file with a |
| - // human unreadable name like /blah/.d41d8cd98f00b204e9800998ecf8427e. |
| - FilePath path; |
| + // Selected file's user friendly path as seen in the UI. |
| + FilePath file_path; |
|
achuithb
2012/07/25 18:11:23
What's the rationale for changing this name from p
tbarzic
2012/07/25 18:42:59
actually, |real_path| has taken over the role of |
|
| + |
| + // The actual local path to the selected file. This can be a snapshot file |
| + // with a human unreadable name like /blah/.d41d8cd98f00b204e9800998ecf8427e. |
| + // |real_path| can differ from |file_path| for drive files (e.g. |
| + // /drive_cache/temporary/d41d8cd98f00b204e9800998ecf8427e vs. |
| + // /special/drive/foo.txt). |
| + FilePath real_path; |
|
achuithb
2012/07/25 18:11:23
Is local_path a better name?
tbarzic
2012/07/25 18:42:59
Done.
|
| // This field is optional. The display name contains only the base name |
| // portion of a file name (ex. no path separators), and used for displaying |
| @@ -26,8 +32,8 @@ struct UI_EXPORT SelectedFileInfo { |
| FilePath::StringType display_name; |
| SelectedFileInfo(); |
| - SelectedFileInfo(const FilePath& in_path, |
| - const FilePath::StringType& in_display_name); |
| + SelectedFileInfo(const FilePath& in_file_path, |
| + const FilePath& in_real_path); |
| ~SelectedFileInfo(); |
| }; |