Fix open dialog not remembering last opened folder on drive

ui/base/dialogs/selected_file_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_DIALOGS_SELECTED_FILE_INFO_H_
 #define UI_BASE_DIALOGS_SELECTED_FILE_INFO_H_
 
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/string16.h"
 #include "ui/base/ui_export.h"
 
 namespace ui {
 
 // Struct used for passing selected file info to WebKit.
 struct UI_EXPORT SelectedFileInfo {
-  // The real path to the selected file. This can be a snapshot file with a
-  // human unreadable name like /blah/.d41d8cd98f00b204e9800998ecf8427e.
-  FilePath path;
+  // Selected file's user friendly path as seen in the UI.
+  FilePath file_path;

[achuithb, 2012/07/25 18:11:23]

What's the rationale for changing this name from path? It seems like you'd need
to touch a lot fewer files if you just called these path and real_path. 

[tbarzic, 2012/07/25 18:42:59]

actually, |real_path| has taken over the role of |path|. If it was the other
way, I'd keep |path|, but in this case, I think it would be more confusing..

+
+  // The actual local path to the selected file. This can be a snapshot file
+  // with a human unreadable name like /blah/.d41d8cd98f00b204e9800998ecf8427e.
+  // |real_path| can differ from |file_path| for drive files (e.g.
+  // /drive_cache/temporary/d41d8cd98f00b204e9800998ecf8427e vs.
+  // /special/drive/foo.txt).
+  FilePath real_path;

[achuithb, 2012/07/25 18:11:23]

Is local_path a better name? 

[tbarzic, 2012/07/25 18:42:59]

Done.

 
   // This field is optional. The display name contains only the base name
   // portion of a file name (ex. no path separators), and used for displaying
   // selected file names. If this field is empty, the base name portion of
   // |path| is used for displaying.
   FilePath::StringType display_name;
 
   SelectedFileInfo();
-  SelectedFileInfo(const FilePath& in_path,
-                   const FilePath::StringType& in_display_name);
+  SelectedFileInfo(const FilePath& in_file_path,
+                   const FilePath& in_real_path);
   ~SelectedFileInfo();
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_DIALOGS_SELECTED_FILE_INFO_H_