HiDPI assets for Chrome OS Files app

HiDPI assets for Chrome OS Files app


BUG=136947
TEST=Open Files app, icons should not be jagged.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147642

[Vladislav Kaznacheev, 2012-07-18 17:09:56]

Please review.

[dgozman, 2012-07-19 13:02:09]

There is a changed file icon16.png. Intentional?

LGTM

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/css/file_manager.css:488:
background-image: url(../images/files/ui/spinner.svg);
Moving spinner to images/commons makes sense to me.

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/media/media_util.js (right):

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/media/media_util.js:11: function
ThumbnailLoader(url, opt_metadata, opt_mediaType) {
I don't see a single usage of |opt_mediaType|.

[Vladislav Kaznacheev, 2012-07-19 13:30:19]

All changes to the existing icons are intentional. Ken polished them a bit.

Thanks for the review!

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/css/file_manager.css:488:
background-image: url(../images/files/ui/spinner.svg);
Moved spinner.svg and spinner_white.svg to images/common.
On 2012/07/19 13:02:09, dgozman wrote:
> Moving spinner to images/commons makes sense to me.

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/media/media_util.js (right):

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/media/media_util.js:11: function
ThumbnailLoader(url, opt_metadata, opt_mediaType) {
Line 97, where we load the fallback url and do not want to derive the media type
from it.

On 2012/07/19 13:02:09, dgozman wrote:
> I don't see a single usage of |opt_mediaType|.

[dgozman, 2012-07-19 13:48:58]

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/media/media_util.js (right):

https://chromiumcodereview.appspot.com/10804010/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/media/media_util.js:11: function
ThumbnailLoader(url, opt_metadata, opt_mediaType) {
On 2012/07/19 13:30:20, Vladislav Kaznacheev wrote:
> Line 97, where we load the fallback url and do not want to derive the media
type
> from it.
> 
> On 2012/07/19 13:02:09, dgozman wrote:
> > I don't see a single usage of |opt_mediaType|.
> 

I meant, there is no invocation with passed opt_mediaType.

[Vladislav Kaznacheev, 2012-07-20 09:33:20]

PTAL (only tools/gritsettings/resource_ids changed, other changes are from
rebase)

[dgozman, 2012-07-20 11:15:28]

LGTM

https://chromiumcodereview.appspot.com/10804010/diff/15007/tools/gritsettings...
File tools/gritsettings/resource_ids (right):

https://chromiumcodereview.appspot.com/10804010/diff/15007/tools/gritsettings...
tools/gritsettings/resource_ids:25: "structures": [1450],
We have more than 250? Wow.