Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4821)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 10804010: HiDPI assets for Chrome OS Files app (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed ID ranges to accommodate new resources Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index 96c0a2e03c0a31742a3032c587ec81b443f10bf3..1e0e1e2dd86317420a45b0fe95b48e519b4ae643 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -1827,7 +1827,7 @@ FileManager.prototype = {
FileManager.prototype.renderIconType_ = function(entry, columnId, table) {
var icon = this.document_.createElement('div');
icon.className = 'detail-icon';
- icon.setAttribute('iconType', FileType.getIcon(entry));
+ icon.setAttribute('file-type-icon', FileType.getIcon(entry));
return icon;
};
@@ -1873,9 +1873,10 @@ FileManager.prototype = {
var div = this.document_.createElement('div');
div.className = 'root-label';
- div.setAttribute('type', rootType);
+ div.setAttribute('volume-type-icon', rootType);
if (rootType === RootType.REMOVABLE)
- div.setAttribute('subType', this.volumeManager_.getDeviceType(path));
+ div.setAttribute('volume-subtype',
+ this.volumeManager_.getDeviceType(path));
div.textContent = this.getRootLabel_(path);
li.appendChild(div);
@@ -1898,12 +1899,6 @@ FileManager.prototype = {
cr.defineProperty(li, 'lead', cr.PropertyKind.BOOL_ATTR);
cr.defineProperty(li, 'selected', cr.PropertyKind.BOOL_ATTR);
- var icon = rootType;
- if (this.volumeManager_.isUnreadable(path)) {
- icon = 'unreadable';
- }
- div.setAttribute('icon', icon);
-
return li;
};
@@ -3170,12 +3165,12 @@ FileManager.prototype = {
if (show) {
var html = util.htmlUnescape(str('DOWNLOADS_DIRECTORY_WARNING'));
- box.lastElementChild.innerHTML = html;
+ box.innerHTML = html;
var link = box.querySelector('a');
link.addEventListener('click',
this.onExternalLinkClick_.bind(this, DOWNLOADS_FAQ_URL));
} else {
- box.lastElementChild.innerHTML = '';
+ box.innerHTML = '';
}
box.hidden = !show;

Powered by Google App Engine
This is Rietveld 408576698