Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 10803032: Move all Copy* methods from descriptor array into the Copy* versions on the map. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Move all Copy* methods from descriptor array into the Copy* versions on the map. Another step towards moving LastAdded from the DescriptorArray to the Map. Committed: https://code.google.com/p/v8/source/detail?r=12145

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -113 lines) Patch
M src/objects.h View 1 2 chunks +4 lines, -11 lines 0 comments Download
M src/objects.cc View 6 chunks +101 lines, -102 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL.
8 years, 5 months ago (2012-07-19 10:34:17 UTC) #1
Jakob Kummerow
LGTM with a nit. https://chromiumcodereview.appspot.com/10803032/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10803032/diff/1/src/objects.h#newcode4905 src/objects.h:4905: DescriptorArray* descs, String* name, int ...
8 years, 5 months ago (2012-07-19 12:55:10 UTC) #2
Toon Verwaest
8 years, 5 months ago (2012-07-19 14:04:49 UTC) #3
Addressed comments.

Powered by Google App Engine
This is Rietveld 408576698