Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: src/objects.h

Issue 10803032: Move all Copy* methods from descriptor array into the Copy* versions on the map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 9e7a128dc6b763553f722dc31bff21f391833b6d..4a7b0c21f0cf1f7cf7021bf28e8a1f05ae25647b 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -2555,16 +2555,6 @@ class DescriptorArray: public FixedArray {
int src_index,
const WhitenessWitness&);
- // Copy the descriptor array, inserting new descriptor. Its enumeration index
- // is automatically set to the size of the descriptor array to which it was
- // added first.
- MUST_USE_RESULT MaybeObject* CopyAdd(Descriptor* descriptor);
-
- // Copy the descriptor array, replacing a descriptor. Its enumeration index is
- // kept.
- MUST_USE_RESULT MaybeObject* CopyReplace(Descriptor* descriptor,
- int insertion_index);
-
// Indicates whether the search function should expect a sorted or an unsorted
// descriptor array as input.
enum SharedMode {
@@ -4912,7 +4902,10 @@ class Map: public HeapObject {
MUST_USE_RESULT MaybeObject* CopyWithPreallocatedFieldDescriptors();
MUST_USE_RESULT MaybeObject* CopyDropDescriptors();
MUST_USE_RESULT MaybeObject* CopyReplaceDescriptors(
- DescriptorArray* descriptors, String* name, TransitionFlag flag);
+ DescriptorArray* descriptors,
+ String* name,
+ int last_added,
+ TransitionFlag flag);
MUST_USE_RESULT MaybeObject* CopyAddDescriptor(Descriptor* descriptor,
TransitionFlag flag);
MUST_USE_RESULT MaybeObject* CopyInsertDescriptor(Descriptor* descriptor,
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698