Issue 10803026: Get content_browsertest working. I've added a simple test for now, and will convert the tests in sr…

Issue 10803026: Get content_browsertest working. I've added a simple test for now, and will convert the tests in sr… (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, apatrick_chromium, yoshiki+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get content_browsertest working. I've added a simple test for now, and will convert the tests in src/content in future changes. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147404

Patch Set 1 : #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : get it working on mac + linux, fix unittests crash, and fix unittest link error and add missing dep… #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+427 lines, -122 lines)			Patch
M	chrome/browser/extensions/permissions_updater_unittest.cc	View	1 2	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_browsertest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		6 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/test/base/chrome_test_launcher.cc	View	1	4 chunks	+26 lines, -0 lines	0 comments	Download
M	chrome/test/base/testing_profile.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View		11 chunks	+13 lines, -55 lines	0 comments	Download
M	chrome/test/gpu/test_support_gpu.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/perf/rendering/throughput_tests.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1 2	5 chunks	+11 lines, -1 line	0 comments	Download
M	content/public/test/browser_test.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
A	content/public/test/browser_test_utils.h	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	content/public/test/test_launcher.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	content/shell/shell.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.cc	View		3 chunks	+13 lines, -0 lines	0 comments	Download
A	content/test/browser_test_utils.cc	View	1 2	1 chunk	+59 lines, -0 lines	0 comments	Download
M	content/test/content_browser_test.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	content/test/content_browser_test.cc	View	1 2	4 chunks	+30 lines, -6 lines	0 comments	Download
A	content/test/content_browser_test_test.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	content/test/content_browser_test_utils.h	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	content/test/content_browser_test_utils.cc	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	content/test/content_test_launcher.cc	View	1 2	2 chunks	+78 lines, -8 lines	0 comments	Download
A	content/test/data/simple_page.html	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/test/test_launcher.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	content/test/test_navigation_observer.cc	View		2 chunks	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10803026/diff/2007/content/shell/shell.h File content/shell/shell.h (right): http://codereview.chromium.org/10803026/diff/2007/content/shell/shell.h#newcode68 content/shell/shell.h:68: static std::vector<Shell*> GetWindows(); const std::... & Could you ...

8 years, 5 months ago (2012-07-18 23:23:34 UTC) #2

jam

http://codereview.chromium.org/10803026/diff/2007/content/shell/shell.h File content/shell/shell.h (right): http://codereview.chromium.org/10803026/diff/2007/content/shell/shell.h#newcode68 content/shell/shell.h:68: static std::vector<Shell*> GetWindows(); On 2012/07/18 23:23:35, sky wrote: > ...

8 years, 5 months ago (2012-07-18 23:44:05 UTC) #3

jam

8 years, 5 months ago (2012-07-19 05:07:58 UTC) #4

btw I had to do a few small changes to make it work on mac+linux (I looked at
what browser_tests did). Also fixed unit_tests linking on Windows and fixed
crashes in it. There are still issues to fix with unit_tests that this change
exposed (I found they were using ui_test_utils.h which seems wrong), but I'll
leave that for future changes.

Expand Messages | Collapse Messages