chrome/test/base/testing_profile.cc - Issue 10803026: Get content_browsertest working. I've added a simple test for now, and will convert the tests in sr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/testing_profile.cc

Issue 10803026: Get content_browsertest working. I've added a simple test for now, and will convert the tests in sr… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: get it working on mac + linux, fix unittests crash, and fix unittest link error and add missing dep… Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/base/testing_profile.cc

===================================================================

--- chrome/test/base/testing_profile.cc (revision 147044)

+++ chrome/test/base/testing_profile.cc (working copy)

@@ -54,6 +54,7 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/render_process_host.h"

+#include "content/public/test/browser_test_utils.h"

#include "content/public/test/mock_resource_context.h"

#include "net/cookies/cookie_monster.h"

#include "net/url_request/url_request_context.h"

@@ -392,8 +393,7 @@

if (GetBookmarkModel()->IsLoaded())

return;

base::RunLoop run_loop;

- BookmarkLoadObserver observer(

- ui_test_utils::GetQuitTaskForRunLoop(&run_loop));

+ BookmarkLoadObserver observer(content::GetQuitTaskForRunLoop(&run_loop));

GetBookmarkModel()->AddObserver(&observer);

run_loop.Run();

GetBookmarkModel()->RemoveObserver(&observer);

« no previous file with comments | « chrome/test/base/chrome_test_launcher.cc ('k') | chrome/test/base/ui_test_utils.h » ('j') | no next file with comments »