Remove non-streaming translation code from pnacl coordinator

Remove non-streaming translation code from pnacl coordinator

R=jvoung@chromium.org,robertm@chromium.org
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2195
TEST=nacl_integration (on nacl bots)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148030

[Derek Schuff, 2012-07-23 21:02:04]

https://chromiumcodereview.appspot.com/10800084/diff/1/chrome/test/nacl_test_...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

https://chromiumcodereview.appspot.com/10800084/diff/1/chrome/test/nacl_test_...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:1: #!/usr/bin/env
python
this is just to make the chrome trybots run pnacl. will be removed

[jvoung - send to chromium..., 2012-07-23 21:22:11]

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc (left):

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc:42:
pexe_wrapper_ = pexe_wrapper;
Since the streamer doesn't use a pexe_desc, could we just remove this argument
(and the field "pexe_wrapper_")?

I guess in the original case, that was the only way to "PutBytes" related to the
bitcode.

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h (right):

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h:63: bool
RunLdSubprocess(int is_shared_library,
nit: Might be more symmetric if this was DoLink() or something.  Otherwise, it
looks like it is paired with RunTranslate().  Then again, DoTranslate() covers
the compile and the link... and there is no separate DoCompile() step.

[Derek Schuff, 2012-07-23 21:51:56]

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc (left):

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc:42:
pexe_wrapper_ = pexe_wrapper;
On 2012/07/23 21:22:11, jvoung wrote:
> Since the streamer doesn't use a pexe_desc, could we just remove this argument
> (and the field "pexe_wrapper_")?
> 
> I guess in the original case, that was the only way to "PutBytes" related to
the
> bitcode.

Done.

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h (right):

https://chromiumcodereview.appspot.com/10800084/diff/1/ppapi/native_client/sr...
ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h:63: bool
RunLdSubprocess(int is_shared_library,
yeah, the division was more because RunLdSubprocess was common to both types of
translation. it might make sense to refactor this a little more, but i wasn't
sure whether to put it in this CL or not. I could go either way.

On 2012/07/23 21:22:11, jvoung wrote:
> nit: Might be more symmetric if this was DoLink() or something.  Otherwise, it
> looks like it is paired with RunTranslate().  Then again, DoTranslate() covers
> the compile and the link... and there is no separate DoCompile() step.

[jvoung (off chromium), 2012-07-23 22:06:21]

lgtm

[commit-bot: I haz the power, 2012-07-23 22:41:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/10800084/6001

[commit-bot: I haz the power, 2012-07-23 23:07:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/10800084/7004

[commit-bot: I haz the power, 2012-07-24 00:09:42]

Try job failure for 10800084-7004 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-24 00:26:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/10800084/7004

[commit-bot: I haz the power, 2012-07-24 01:57:57]

Change committed as 148030