Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2405)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h

Issue 10800084: Remove non-streaming translation code from pnacl coordinator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h
index 5277739d5efc2de408ac51fec1c94460f1e9cae1..199e7a7dbc50fad68a65a803890cb5d1270b537e 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h
@@ -38,10 +38,9 @@ class PnaclTranslateThread {
const Manifest* ld_manifest,
LocalTempFile* obj_file,
LocalTempFile* nexe_file,
- nacl::DescWrapper* pexe_wrapper,
ErrorInfo* error_info,
PnaclResources* resources,
- Plugin* plugin);
+ Plugin* plugin) = 0;
// Returns true if the translate thread and subprocesses should stop.
bool SubprocessesShouldDie();
// Signal the translate thread and subprocesses that they should stop.
@@ -56,7 +55,7 @@ class PnaclTranslateThread {
// PnaclTranslateThread and calls DoTranslate().
static void WINAPI DoTranslateThread(void* arg);
// Runs the SRPCs that control translation. Called from the helper thread.
- virtual void DoTranslate();
+ virtual void DoTranslate() = 0;
// Signal that Pnacl translation failed, from the translation thread only.
void TranslateFailed(const nacl::string& error_string);
// Run the LD subprocess, returning true on success
@@ -78,7 +77,6 @@ class PnaclTranslateThread {
const Manifest* ld_manifest_;
LocalTempFile* obj_file_;
LocalTempFile* nexe_file_;
- nacl::DescWrapper* pexe_wrapper_;
ErrorInfo* coordinator_error_info_;
PnaclResources* resources_;
Plugin* plugin_;

Powered by Google App Engine
This is Rietveld 408576698