Issue 10799013: Removing unused and private methods remoting::Capturer interface.

Issue 10799013: Removing unused and private methods remoting::Capturer interface. (Closed)

Created:
8 years, 5 months ago by alexeypa (please no reviews)

Modified:
8 years, 5 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing unused and private methods remoting::Capturer interface. BUG=104542 TEST=remoting_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147574

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback. #

Patch Set 3 : rebased #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -155 lines)			Patch
M	remoting/host/host_mock_objects.h	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	remoting/host/screen_recorder.cc	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	remoting/host/screen_recorder_unittest.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	remoting/host/video_frame_capturer.h	View	1 2	1 chunk	+0 lines, -13 lines	0 comments	Download
M	remoting/host/video_frame_capturer_fake.h	View	1 2	2 chunks	+3 lines, -4 lines	0 comments	Download
M	remoting/host/video_frame_capturer_fake.cc	View	1 2	2 chunks	+13 lines, -25 lines	0 comments	Download
M	remoting/host/video_frame_capturer_linux.cc	View	1 2	4 chunks	+12 lines, -26 lines	0 comments	Download
M	remoting/host/video_frame_capturer_mac.mm	View	1 2	4 chunks	+45 lines, -58 lines	0 comments	Download
M	remoting/host/video_frame_capturer_win.cc	View	1 2	6 chunks	+6 lines, -23 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM - thanks for taking care of this. BUG should be 104542. Please add the ...

8 years, 5 months ago (2012-07-18 20:31:19 UTC) #2

alexeypa (please no reviews)

http://codereview.chromium.org/10799013/diff/1/remoting/host/capturer_mac.mm File remoting/host/capturer_mac.mm (right): http://codereview.chromium.org/10799013/diff/1/remoting/host/capturer_mac.mm#newcode197 remoting/host/capturer_mac.mm:197: void ScreenConfigurationChanged(); On 2012/07/18 20:31:19, Wez wrote: > Add ...

8 years, 5 months ago (2012-07-18 20:51:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10799013/10002

8 years, 5 months ago (2012-07-19 21:35:18 UTC) #4

commit-bot: I haz the power

Try job failure for 10799013-10002 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 5 months ago (2012-07-19 22:41:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10799013/10002

8 years, 5 months ago (2012-07-19 22:57:11 UTC) #6

Change committed as 147574

Expand Messages | Collapse Messages