Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issue 10796066: Merge 122883 - vertical-align: middle causes overflow with subpixel layout (Closed)

Created:
8 years, 5 months ago by eae
Modified:
8 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 122883 - vertical-align: middle causes overflow with subpixel layout https://bugs.webkit.org/show_bug.cgi?id=91464 Reviewed by Eric Seidel. Source/WebCore: Using vertical-align: middle in combination with an overflow value other than visible can cause the overflow height to be computed incorrectly. Test: fast/sub-pixel/vertical-align-middle-overflow.html * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::verticalPositionForBox): Round verticalPosition after calculation instead of flooring the result of the xHeight calculation. By flooring it the resulting value is in effect rounded up which can cause the height of the box to grow by one. By rounding the resulting value thevertical position is more accurate and the off by one error is avoided. LayoutTests: Add new test for vertical-align: middle and adjust existing results to reflect the improved alignment calculation. * fast/sub-pixel/vertical-align-middle-overflow-expected.txt: Added. * fast/sub-pixel/vertical-align-middle-overflow.html: Added. * platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png: * platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: * platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png: * platform/chromium-linux/fast/inline/002-expected.png: * platform/chromium-linux/fast/table/table-display-types-strict-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: * platform/chromium-mac-snowleopard/fast/block/basic/014-expected.png: * platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png: * platform/chromium-mac-snowleopard/fast/inline/002-expected.png: * platform/chromium-mac-snowleopard/fast/table/table-display-types-strict-expected.png: * platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png: * platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png: * platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: * platform/chromium-mac/css1/text_properties/vertical_align-expected.txt: * platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: * platform/chromium-mac/fast/block/basic/014-expected.txt: * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.txt: * platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt: * platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt: * platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: * platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt: * platform/chromium-win/css1/text_properties/vertical_align-expected.txt: * platform/chromium-win/fast/block/basic/014-expected.txt: * platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt: * platform/chromium-win/fast/inline/002-expected.txt: * platform/chromium-win/fast/table/table-display-types-strict-expected.txt: * platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt: * platform/mac/fast/inline/002-expected.txt: * platform/mac/fast/replaced/008-expected.png: * platform/mac/fast/table/table-display-types-strict-expected.txt: TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -229 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +45 lines, -0 lines 0 comments Download
A + LayoutTests/fast/sub-pixel/vertical-align-middle-overflow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/sub-pixel/vertical-align-middle-overflow-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt View 2 chunks +37 lines, -37 lines 0 comments Download
M LayoutTests/platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/fast/inline/002-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/fast/table/table-display-types-strict-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-mac-snowleopard/fast/block/basic/014-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-mac-snowleopard/fast/inline/002-expected.png View Binary file 0 comments Download
MM LayoutTests/platform/chromium-mac-snowleopard/fast/table/table-display-types-strict-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.txt View 14 chunks +77 lines, -77 lines 0 comments Download
M LayoutTests/platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt View 2 chunks +37 lines, -37 lines 0 comments Download
M LayoutTests/platform/chromium-mac/fast/block/basic/014-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/chromium-win/css1/text_properties/vertical_align-expected.txt View 4 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/block/basic/014-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/fast/inline/002-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/table/table-display-types-strict-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/compositing/reflections/animation-inside-reflection-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/inline/002-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/replaced/008-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/table/table-display-types-strict-expected.txt View 3 chunks +39 lines, -39 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
eae
8 years, 5 months ago (2012-07-20 18:00:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698