Source/WebCore/ChangeLog - Issue 10796066: Merge 122883 - vertical-align: middle causes overflow with subpixel layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.

Issue 10796066: Merge 122883 - vertical-align: middle causes overflow with subpixel layout (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « LayoutTests/platform/mac/fast/table/table-display-types-strict-expected.txt ('k') | Source/WebCore/rendering/RootInlineBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/ChangeLog

===================================================================

--- Source/WebCore/ChangeLog (revision 123234)

+++ Source/WebCore/ChangeLog (working copy)

@@ -1,5 +1,25 @@

2012-07-17 Emil A Eklund <eae@chromium.org>

+ vertical-align: middle causes overflow with subpixel layout

+ https://bugs.webkit.org/show_bug.cgi?id=91464

+ Reviewed by Eric Seidel.

+ Using vertical-align: middle in combination with an overflow value other

+ than visible can cause the overflow height to be computed incorrectly.

+ Test: fast/sub-pixel/vertical-align-middle-overflow.html

+ * rendering/RootInlineBox.cpp:

+ (WebCore::RootInlineBox::verticalPositionForBox):

+ Round verticalPosition after calculation instead of flooring the result

+ of the xHeight calculation. By flooring it the resulting value is in

+ effect rounded up which can cause the height of the box to grow by one.

+ By rounding the resulting value thevertical position is more accurate and

+ the off by one error is avoided.

+2012-07-17 Emil A Eklund <eae@chromium.org>

Incorrect offset used for scrollWidth/Height calculation

https://bugs.webkit.org/show_bug.cgi?id=91461