Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 10795080: A couple of multiple displays support fixes. (Closed)

Created:
8 years, 5 months ago by oshima
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

* Fix coordinates for minimize animation * Update the display bounds correctly in |Fix coordinates for minimize animation|. Update the test so that it will fail with original code, and removed the debugging message that was checked in by mistake. * Update the display layout after the secondary display is initialized on startup. * Fix comment in Display.h. It was probably cut&paste error. BUG=123160 TEST=Updated MultiDisplayTest::NativeDisplayTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148056

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M ash/display/display_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/multi_display_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/display/multi_display_manager_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ash/wm/window_animations.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gfx/display.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
8 years, 5 months ago (2012-07-23 23:20:15 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-24 04:10:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10795080/20
8 years, 5 months ago (2012-07-24 04:26:02 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 06:07:22 UTC) #4
Change committed as 148056

Powered by Google App Engine
This is Rietveld 408576698