Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: gpu/command_buffer/service/program_manager.cc

Issue 10795037: Revert 147328 - Current status of patch: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager.cc
===================================================================
--- gpu/command_buffer/service/program_manager.cc (revision 147496)
+++ gpu/command_buffer/service/program_manager.cc (working copy)
@@ -4,9 +4,7 @@
#include "gpu/command_buffer/service/program_manager.h"
-#include <algorithm>
#include <set>
-#include <utility>
#include <vector>
#include "base/basictypes.h"
@@ -16,10 +14,8 @@
#include "base/string_number_conversions.h"
#include "gpu/command_buffer/common/gles2_cmd_format.h"
#include "gpu/command_buffer/common/gles2_cmd_utils.h"
-#include "gpu/command_buffer/service/feature_info.h"
#include "gpu/command_buffer/service/gles2_cmd_decoder.h"
#include "gpu/command_buffer/service/gpu_switches.h"
-#include "gpu/command_buffer/service/program_cache.h"
namespace gpu {
namespace gles2 {
@@ -38,21 +34,6 @@
}
}
-ShaderTranslator* ShaderIndexToTranslator(
- int index,
- ShaderTranslator* vertex_translator,
- ShaderTranslator* fragment_translator) {
- switch (index) {
- case 0:
- return vertex_translator;
- case 1:
- return fragment_translator;
- default:
- NOTREACHED();
- return NULL;
- }
-}
-
// Given a name like "foo.bar[123].moo[456]" sets new_name to "foo.bar[123].moo"
// and sets element_index to 456. returns false if element expression was not a
// whole decimal number. For example: "foo[1b2]"
@@ -379,83 +360,7 @@
}
}
-void ProgramManager::DoCompileShader(ShaderManager::ShaderInfo* info,
- ShaderTranslator* translator,
- FeatureInfo* feature_info) {
- if (program_cache_ &&
- program_cache_->GetShaderCompilationStatus(*info->source()) ==
- ProgramCache::COMPILATION_SUCCEEDED) {
- info->SetStatus(true, "", translator);
- info->FlagSourceAsCompiled(false);
- return;
- }
- ForceCompileShader(info->source(), info, translator, feature_info);
-}
-
-void ProgramManager::ForceCompileShader(const std::string* source,
- ShaderManager::ShaderInfo* info,
- ShaderTranslator* translator,
- FeatureInfo* feature_info) {
- info->FlagSourceAsCompiled(true);
-
- // Translate GL ES 2.0 shader to Desktop GL shader and pass that to
- // glShaderSource and then glCompileShader.
- const char* shader_src = source ? source->c_str() : "";
- if (translator) {
- if (!translator->Translate(shader_src)) {
- info->SetStatus(false, translator->info_log(), NULL);
- return;
- }
- shader_src = translator->translated_shader();
- if (!feature_info->feature_flags().angle_translated_shader_source)
- info->UpdateTranslatedSource(shader_src);
- }
-
- glShaderSource(info->service_id(), 1, &shader_src, NULL);
- glCompileShader(info->service_id());
- if (feature_info->feature_flags().angle_translated_shader_source) {
- GLint max_len = 0;
- glGetShaderiv(info->service_id(),
- GL_TRANSLATED_SHADER_SOURCE_LENGTH_ANGLE,
- &max_len);
- scoped_array<char> temp(new char[max_len]);
- GLint len = 0;
- glGetTranslatedShaderSourceANGLE(
- info->service_id(), max_len, &len, temp.get());
- DCHECK(max_len == 0 || len < max_len);
- DCHECK(len == 0 || temp[len] == '\0');
- info->UpdateTranslatedSource(temp.get());
- }
-
- GLint status = GL_FALSE;
- glGetShaderiv(info->service_id(), GL_COMPILE_STATUS, &status);
- if (status) {
- info->SetStatus(true, "", translator);
- if (program_cache_) {
- const char* untranslated_source = source ? source->c_str() : "";
- program_cache_->ShaderCompilationSucceeded(untranslated_source);
- }
- } else {
- // We cannot reach here if we are using the shader translator.
- // All invalid shaders must be rejected by the translator.
- // All translated shaders must compile.
- LOG_IF(ERROR, translator)
- << "Shader translator allowed/produced an invalid shader.";
- GLint max_len = 0;
- glGetShaderiv(info->service_id(), GL_INFO_LOG_LENGTH, &max_len);
- scoped_array<char> temp(new char[max_len]);
- GLint len = 0;
- glGetShaderInfoLog(info->service_id(), max_len, &len, temp.get());
- DCHECK(max_len == 0 || len < max_len);
- DCHECK(len == 0 || temp[len] == '\0');
- info->SetStatus(false, std::string(temp.get(), len).c_str(), NULL);
- }
-}
-
-bool ProgramManager::ProgramInfo::Link(ShaderManager* manager,
- ShaderTranslator* vertex_translator,
- ShaderTranslator* fragment_translator,
- FeatureInfo* feature_info) {
+bool ProgramManager::ProgramInfo::Link() {
ClearLinkStatus();
if (!CanLink()) {
set_log_info("missing shaders");
@@ -466,70 +371,11 @@
return false;
}
ExecuteBindAttribLocationCalls();
-
- bool link = true;
- ProgramCache* cache = manager_->program_cache_;
- const std::string* shader_a =
- attached_shaders_[0]->deferred_compilation_source();
- const std::string* shader_b =
- attached_shaders_[1]->deferred_compilation_source();
- if (cache) {
- ProgramCache::LinkedProgramStatus status = cache->GetLinkedProgramStatus(
- *shader_a,
- *shader_b,
- &bind_attrib_location_map_);
- switch (status) {
- case ProgramCache::LINK_SUCCEEDED: {
- ProgramCache::ProgramLoadResult success = cache->LoadLinkedProgram(
- service_id(),
- attached_shaders_[0],
- attached_shaders_[1],
- &bind_attrib_location_map_);
- if (success == ProgramCache::PROGRAM_LOAD_SUCCESS) {
- link = false;
- break;
- }
- }
- // no break
- case ProgramCache::LINK_UNKNOWN: {
- // compile our shaders + attach
- const int kShaders = ProgramManager::ProgramInfo::kMaxAttachedShaders;
- for (int i = 0; i < kShaders; ++i) {
- ShaderManager::ShaderInfo* info = attached_shaders_[i].get();
- if (!info->source_compiled()) {
- ShaderTranslator* translator = ShaderIndexToTranslator(
- i,
- vertex_translator,
- fragment_translator);
- manager_->ForceCompileShader(info->deferred_compilation_source(),
- attached_shaders_[i],
- translator,
- feature_info);
- CHECK(info->IsValid());
- }
- }
- link = true;
- break;
- }
- default:
- NOTREACHED();
- }
- }
-
- if (link) {
- glLinkProgram(service_id());
- }
-
+ glLinkProgram(service_id());
GLint success = 0;
glGetProgramiv(service_id(), GL_LINK_STATUS, &success);
if (success == GL_TRUE) {
Update();
- if (cache && link) {
- cache->SaveLinkedProgram(service_id(),
- attached_shaders_[0],
- attached_shaders_[1],
- &bind_attrib_location_map_);
- }
} else {
UpdateLogInfo();
}
@@ -1002,14 +848,13 @@
}
}
-
-ProgramManager::ProgramManager(ProgramCache* program_cache)
+ProgramManager::ProgramManager()
: program_info_count_(0),
have_context_(true),
disable_workarounds_(
CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDisableGpuDriverBugWorkarounds)),
- program_cache_(program_cache) { }
+ switches::kDisableGpuDriverBugWorkarounds)) {
+}
ProgramManager::~ProgramManager() {
DCHECK(program_infos_.empty());
@@ -1055,10 +900,6 @@
return false;
}
-ProgramCache* ProgramManager::program_cache() const {
- return program_cache_;
-}
-
bool ProgramManager::IsOwned(ProgramManager::ProgramInfo* info) {
for (ProgramInfoMap::iterator it = program_infos_.begin();
it != program_infos_.end(); ++it) {
« no previous file with comments | « gpu/command_buffer/service/program_manager.h ('k') | gpu/command_buffer/service/program_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698