chrome/browser/chromeos/status/data_promo_notification.cc - Issue 10795013: Rename bounds accessors to be intuitive and consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/status/data_promo_notification.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/status/data_promo_notification.cc

diff --git a/chrome/browser/chromeos/status/data_promo_notification.cc b/chrome/browser/chromeos/status/data_promo_notification.cc

index 8be6d77ea90c39b0e0adf44ed0ff3a9527eba0f0..a4dfed1eb3fddfd196d2aa56727851922506d43c 100644

--- a/chrome/browser/chromeos/status/data_promo_notification.cc

+++ b/chrome/browser/chromeos/status/data_promo_notification.cc

@@ -160,7 +160,7 @@ void DataPromoNotification::ShowOptionalMobileDataPromoNotification(

return;

}

- gfx::Rect button_bounds = host->GetScreenBounds();

+ gfx::Rect button_bounds = host->GetBoundsInScreen();

// StatusArea button Y position is usually -1, fix it so that

// Contains() method for screen bounds works correctly.

button_bounds.set_y(button_bounds.y() + 1);