Convert more PyAuto proxy calls to the JSON interface.

Convert more PyAuto proxy calls to the JSON interface.

Converts: ActivateTab, GetTabCount, GetActiveTabTitle, GetActiveTabURL
Adds: BringBrowserToFront, GetTabInfo

BUG=132794
TEST=PyAuto CONTINUOUS suite


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147748

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148222

[Nirnimesh, 2012-07-18 19:22:56]

https://chromiumcodereview.appspot.com/10790055/diff/1/chrome/test/pyautolib/...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10790055/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:1224: tab_index: Integer index of the tab to
activate; defaults to the first
'first tab' -> 0

https://chromiumcodereview.appspot.com/10790055/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:1237: self.BringBrowserToFront(windex)
shouldn't this be done on the C++ side?

[craigdh, 2012-07-18 19:45:25]

https://chromiumcodereview.appspot.com/10790055/diff/1/chrome/test/pyautolib/...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10790055/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:1224: tab_index: Integer index of the tab to
activate; defaults to the first
On 2012/07/18 19:22:56, Nirnimesh wrote:
> 'first tab' -> 0

Done.

https://chromiumcodereview.appspot.com/10790055/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:1237: self.BringBrowserToFront(windex)
On 2012/07/18 19:22:56, Nirnimesh wrote:
> shouldn't this be done on the C++ side?

Bringing the browser to the front is available in Python via the BrowserProxy.
ActivateTab() was previously implemented in pyautolib.cc by two separate browser
proxy calls (one to bring the browser forward and one to activate the tab). The
reason it's still separate here is because the JSON interface version of
ActivateTab already exists for ChromeDriver but does not bring the window to the
front, and the BringBrowserToFront needed to be implemented for the browser
proxy interface anyway. So this saves adding an additional automation function
that would be nearly identical to one that already exists.

[Nirnimesh, 2012-07-18 20:17:32]

LGTM

[commit-bot: I haz the power, 2012-07-20 00:30:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10790055/5001

[commit-bot: I haz the power, 2012-07-20 00:31:04]

Presubmit check for 10790055-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/automation

[craigdh, 2012-07-20 00:53:30]

Apparently an owners file has now been added. This is a refactoring change, part
of a larger series to move the automation calls to a consistent JSON interface.
The old functions are not removed in this CL as I plan to only break binary
compatibility once.

[jam, 2012-07-20 06:02:38]

lgtm

[commit-bot: I haz the power, 2012-07-20 23:24:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10790055/5001

[commit-bot: I haz the power, 2012-07-21 00:34:30]

Change committed as 147748

[commit-bot: I haz the power, 2012-07-24 20:34:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10790055/1007

[commit-bot: I haz the power, 2012-07-24 22:14:25]

Change committed as 148222