Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5124)

Unified Diff: chrome/test/pyautolib/pyautolib.cc

Issue 10790055: Convert more PyAuto proxy calls to the JSON interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ensure the returned Python string is of type str, not unicode, before passing to GURL. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/pyautolib/pyautolib.h ('k') | chrome/test/pyautolib/pyautolib.i » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/pyautolib/pyautolib.cc
diff --git a/chrome/test/pyautolib/pyautolib.cc b/chrome/test/pyautolib/pyautolib.cc
index 91da779b4c5cac635dfe14cc81da5e3c10353e89..87b89ee070c9736b77c82f80cdfdd62f1b3f2572 100644
--- a/chrome/test/pyautolib/pyautolib.cc
+++ b/chrome/test/pyautolib/pyautolib.cc
@@ -101,11 +101,6 @@ void PyUITestBase::SetLaunchSwitches() {
launch_arguments_.AppendSwitchASCII(switches::kHomePage, homepage_);
}
-bool PyUITestBase::ActivateTab(int tab_index, int window_index) {
- scoped_refptr<BrowserProxy> browser_proxy = GetBrowserWindow(window_index);
- return browser_proxy->BringToFront() && browser_proxy->ActivateTab(tab_index);
-}
-
void PyUITestBase::SetDownloadShelfVisible(bool is_visible, int window_index) {
scoped_refptr<BrowserProxy> browser_proxy = GetBrowserWindow(window_index);
ASSERT_TRUE(browser_proxy.get());
@@ -122,14 +117,6 @@ bool PyUITestBase::IsDownloadShelfVisible(int window_index) {
return visible;
}
-int PyUITestBase::GetTabCount(int window_index) {
- return UITestBase::GetTabCount(window_index);
-}
-
-GURL PyUITestBase::GetActiveTabURL(int window_index) {
- return UITestBase::GetActiveTabURL(window_index);
-}
-
void PyUITestBase::OpenFindInPage(int window_index) {
scoped_refptr<BrowserProxy> browser_proxy = GetBrowserWindow(window_index);
ASSERT_TRUE(browser_proxy.get());
« no previous file with comments | « chrome/test/pyautolib/pyautolib.h ('k') | chrome/test/pyautolib/pyautolib.i » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698