chrome/browser/safe_browsing/browser_feature_extractor.cc - Issue 10790035: Removing usage of profile_->GetHistory() from the codebase in order to remove that function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor.cc

Issue 10790035: Removing usage of profile_->GetHistory() from the codebase in order to remove that function. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/browser_feature_extractor.cc

===================================================================

--- chrome/browser/safe_browsing/browser_feature_extractor.cc (revision 146646)

+++ chrome/browser/safe_browsing/browser_feature_extractor.cc (working copy)

@@ -15,6 +15,7 @@

#include "base/time.h"

#include "chrome/browser/cancelable_request.h"

#include "chrome/browser/history/history.h"

+#include "chrome/browser/history/history_service_factory.h"

#include "chrome/browser/history/history_types.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/safe_browsing/browser_features.h"

@@ -440,7 +441,8 @@

*history = NULL;

if (tab_ && tab_->GetBrowserContext()) {

Profile* profile = Profile::FromBrowserContext(tab_->GetBrowserContext());

- *history = profile->GetHistoryService(Profile::EXPLICIT_ACCESS);

+ *history = HistoryServiceFactory::GetForProfile(profile,

+ Profile::EXPLICIT_ACCESS);

if (*history) {

return true;

}

« no previous file with comments | « no previous file | chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc » ('j') | no next file with comments »