chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc - Issue 10790035: Removing usage of profile_->GetHistory() from the codebase in order to remove that function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

Issue 10790035: Removing usage of profile_->GetHistory() from the codebase in order to remove that function. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor.cc ('k') | chrome/browser/safe_browsing/malware_details_history.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

===================================================================

--- chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc (revision 146646)

+++ chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc (working copy)

@@ -14,6 +14,7 @@

#include "base/time.h"

#include "chrome/browser/history/history.h"

#include "chrome/browser/history/history_backend.h"

+#include "chrome/browser/history/history_service_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/safe_browsing/browser_features.h"

#include "chrome/browser/safe_browsing/client_side_detection_service.h"

@@ -69,7 +70,8 @@

}

HistoryService* history_service() {

- return profile()->GetHistoryService(Profile::EXPLICIT_ACCESS);

+ return HistoryServiceFactory::GetForProfile(profile(),

+ Profile::EXPLICIT_ACCESS);

}

void SetRedirectChain(const std::vector<GURL>& redirect_chain,