Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 10787042: Coverity: Initialize a member variable. (Closed)

Created:
8 years, 5 months ago by James Hawkins
Modified:
8 years, 5 months ago
Reviewers:
groby-ooo-7-16, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Coverity: Initialize a member variable. CID_COUNT=1 CID=104455 BUG=none TEST=none R=groby TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147247

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nuke. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/histogram_message_filter.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/histogram_message_filter.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Hawkins
8 years, 5 months ago (2012-07-17 17:53:58 UTC) #1
groby-ooo-7-16
lgtm
8 years, 5 months ago (2012-07-17 19:15:22 UTC) #2
sky
https://chromiumcodereview.appspot.com/10787042/diff/1/content/browser/histogram_message_filter.cc File content/browser/histogram_message_filter.cc (right): https://chromiumcodereview.appspot.com/10787042/diff/1/content/browser/histogram_message_filter.cc#newcode15 content/browser/histogram_message_filter.cc:15: : process_type_(PROCESS_TYPE_UNKNOWN) { It doesn't look like this field ...
8 years, 5 months ago (2012-07-17 22:10:55 UTC) #3
James Hawkins
https://chromiumcodereview.appspot.com/10787042/diff/1/content/browser/histogram_message_filter.cc File content/browser/histogram_message_filter.cc (right): https://chromiumcodereview.appspot.com/10787042/diff/1/content/browser/histogram_message_filter.cc#newcode15 content/browser/histogram_message_filter.cc:15: : process_type_(PROCESS_TYPE_UNKNOWN) { On 2012/07/17 22:10:55, sky wrote: > ...
8 years, 5 months ago (2012-07-18 15:24:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10787042/9001
8 years, 5 months ago (2012-07-18 15:24:47 UTC) #5
sky
LGTM
8 years, 5 months ago (2012-07-18 15:25:07 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 16:25:56 UTC) #7
Change committed as 147247

Powered by Google App Engine
This is Rietveld 408576698