Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: content/browser/histogram_message_filter.cc

Issue 10787042: Coverity: Initialize a member variable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/histogram_message_filter.h" 5 #include "content/browser/histogram_message_filter.h"
6 6
7 #include "base/process_util.h" 7 #include "base/process_util.h"
8 #include "content/browser/histogram_controller.h" 8 #include "content/browser/histogram_controller.h"
9 #include "content/browser/tcmalloc_internals_request_job.h" 9 #include "content/browser/tcmalloc_internals_request_job.h"
10 #include "content/common/child_process_messages.h" 10 #include "content/common/child_process_messages.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 HistogramMessageFilter::HistogramMessageFilter() { 14 HistogramMessageFilter::HistogramMessageFilter()
15 : process_type_(PROCESS_TYPE_UNKNOWN) {
sky 2012/07/17 22:10:55 It doesn't look like this field is used at all. Ca
James Hawkins 2012/07/18 15:24:25 Done.
15 } 16 }
16 17
17 void HistogramMessageFilter::OnChannelConnected(int32 peer_pid) { 18 void HistogramMessageFilter::OnChannelConnected(int32 peer_pid) {
18 BrowserMessageFilter::OnChannelConnected(peer_pid); 19 BrowserMessageFilter::OnChannelConnected(peer_pid);
19 } 20 }
20 21
21 bool HistogramMessageFilter::OnMessageReceived(const IPC::Message& message, 22 bool HistogramMessageFilter::OnMessageReceived(const IPC::Message& message,
22 bool* message_was_ok) { 23 bool* message_was_ok) {
23 bool handled = true; 24 bool handled = true;
24 IPC_BEGIN_MESSAGE_MAP_EX(HistogramMessageFilter, message, *message_was_ok) 25 IPC_BEGIN_MESSAGE_MAP_EX(HistogramMessageFilter, message, *message_was_ok)
25 IPC_MESSAGE_HANDLER(ChildProcessHostMsg_ChildHistogramData, 26 IPC_MESSAGE_HANDLER(ChildProcessHostMsg_ChildHistogramData,
26 OnChildHistogramData) 27 OnChildHistogramData)
27 IPC_MESSAGE_UNHANDLED(handled = false) 28 IPC_MESSAGE_UNHANDLED(handled = false)
28 IPC_END_MESSAGE_MAP_EX() 29 IPC_END_MESSAGE_MAP_EX()
29 return handled; 30 return handled;
30 } 31 }
31 32
32 HistogramMessageFilter::~HistogramMessageFilter() {} 33 HistogramMessageFilter::~HistogramMessageFilter() {}
33 34
34 void HistogramMessageFilter::OnChildHistogramData( 35 void HistogramMessageFilter::OnChildHistogramData(
35 int sequence_number, 36 int sequence_number,
36 const std::vector<std::string>& pickled_histograms) { 37 const std::vector<std::string>& pickled_histograms) {
37 HistogramController::GetInstance()->OnHistogramDataCollected( 38 HistogramController::GetInstance()->OnHistogramDataCollected(
38 sequence_number, pickled_histograms); 39 sequence_number, pickled_histograms);
39 } 40 }
40 } 41 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698