Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 10787010: Switch to TimeDelta interfaces in chrome automation test infrastructure. (Closed)

Created:
8 years, 5 months ago by Ted Vessenes
Modified:
8 years, 5 months ago
Reviewers:
jam, ananta, sky
CC:
chromium-reviews, Nirnimesh, grt+watch_chromium.org, amit, kkania, anantha, robertshield, dyu1, dennis_jeffrey
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Switch to TimeDelta interfaces in chrome automation test infrastructure. This is a resubmit of a previously reverted commit: https://chromiumcodereview.appspot.com/10736064/ BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147700

Patch Set 1 #

Patch Set 2 : Add missing base/time.h include. #

Patch Set 3 : Rebase onto master. #

Patch Set 4 : Rebase onto master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -103 lines) Patch
M chrome/test/automation/automation_proxy.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/automation/dom_automation_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/automation/javascript_execution_controller.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/automation/proxy_launcher.h View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 8 chunks +16 lines, -13 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/dom_checker_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/dromaeo_benchmark_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/indexeddb_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/kraken_benchmark_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/page_cycler_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/sunspider_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/tab_switching_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/perf/url_fetch_test.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/perf/v8_benchmark_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/test/reliability/automated_ui_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.h View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 2 7 chunks +21 lines, -12 lines 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 1 2 3 4 chunks +6 lines, -4 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome_frame/test_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ted Vessenes
This failed because base/time.h was missing from an include.
8 years, 5 months ago (2012-07-14 02:16:54 UTC) #1
Ted Vessenes
This seems like a pretty simple fix, but let me know if you need me ...
8 years, 5 months ago (2012-07-16 16:40:09 UTC) #2
ananta
lgtm
8 years, 5 months ago (2012-07-17 18:14:48 UTC) #3
Ted Vessenes
sky@chromium.org: Can you review chrome/test/*? My assignment script originally suggested ben@chromium.org (who reviewed the first ...
8 years, 5 months ago (2012-07-20 00:23:09 UTC) #4
sky
LGTM
8 years, 5 months ago (2012-07-20 15:34:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10787010/7041
8 years, 5 months ago (2012-07-20 18:30:07 UTC) #6
commit-bot: I haz the power
Presubmit check for 10787010-7041 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-20 18:30:33 UTC) #7
Ted Vessenes
That explains why the script suggested Ben-- I missed the noparent on chrome/test/automation/OWNERS. jam@chromium.org: Please ...
8 years, 5 months ago (2012-07-20 18:32:58 UTC) #8
jam
lgtm
8 years, 5 months ago (2012-07-20 18:38:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10787010/7041
8 years, 5 months ago (2012-07-20 18:38:59 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 19:41:58 UTC) #11
Change committed as 147700

Powered by Google App Engine
This is Rietveld 408576698