Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10736064: Switch to TimeDelta interfaces in chrome automation test infrastructure. (Closed)

Created:
8 years, 5 months ago by Ted Vessenes
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Nirnimesh, grt+watch_chromium.org, amit, kkania, anantha, robertshield, dyu1, dennis_jeffrey
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Switch to TimeDelta interfaces in chrome automation test infrastructure. BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -103 lines) Patch
M chrome/test/automation/automation_proxy.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/automation/dom_automation_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/automation/javascript_execution_controller.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/automation/proxy_launcher.h View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 8 chunks +16 lines, -13 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/dom_checker_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/dromaeo_benchmark_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/indexeddb_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/kraken_benchmark_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/page_cycler_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/sunspider_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/tab_switching_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/perf/url_fetch_test.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/perf/v8_benchmark_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/test/reliability/automated_ui_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.h View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 7 chunks +21 lines, -12 lines 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome_frame/test_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted Vessenes
ben@chromium.org: chrome/* ananta@chromium.org: chrome_frame/* This fix involves changing the underlying API to the AutomationProxy interface ...
8 years, 5 months ago (2012-07-13 02:01:55 UTC) #1
ananta
chrome frame changes LGTM
8 years, 5 months ago (2012-07-13 02:07:50 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-07-13 16:37:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10736064/1
8 years, 5 months ago (2012-07-13 17:16:35 UTC) #4
commit-bot: I haz the power
Try job failure for 10736064-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-13 19:57:52 UTC) #5
Ted Vessenes
On 2012/07/13 19:57:52, I haz the power (commit-bot) wrote: > Try job failure for 10736064-1 ...
8 years, 5 months ago (2012-07-13 19:59:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10736064/1
8 years, 5 months ago (2012-07-13 20:00:37 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-13 21:30:47 UTC) #8 
Change committed as 146656

Powered by Google App Engine
This is Rietveld 408576698