Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 10786036: Merge 122552 - REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for inpu… (Closed)

Created:
8 years, 5 months ago by karen
Modified:
8 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 122552 - REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched https://bugs.webkit.org/show_bug.cgi?id=91197 Reviewed by Kent Tamura. Source/WebCore: This patch fixes implementation of Decimal::ceiling() and floor(). They return wrong value for small fractional numbers. The bug is occurred when: - Step-able input type, e.g. number, date, datetime, and so on. - Current value is step mismatched - Current value is smaller than step - Step up/down by spin button because spin button up/down actions are implemented in InputType::setpUpFromRenderer which calls Decimal::ceiling() and floor() for step mismatched case. Tests: fast/forms/number/number-stepup-stepdown-from-renderer.html: Added test cases WebKit/chromium/tests/DecimalTest.cpp: Added test cases * platform/Decimal.cpp: (WebCore::Decimal::ceiling): Changed to return 1 for positive small fractional number. (WebCore::Decimal::floor): Changed to return -1 for negative small fractional number. Source/WebKit/chromium: This patch adds test cases for Decimal::ceiling() and floor() of positive/negative small fractional numbers. * tests/DecimalTest.cpp: (TEST_F): LayoutTests: This patch adds new test cases. * fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Updated for new test cases. * fast/forms/number/number-stepup-stepdown-from-renderer.html: Added new test cases. TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/platform/Decimal.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/tests/DecimalTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 5 months ago (2012-07-17 17:34:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698