Source/WebCore/platform/Decimal.cpp - Issue 10786036: Merge 122552 - REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for inpu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/platform/Decimal.cpp

Issue 10786036: Merge 122552 - REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for inpu… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt ('k') | Source/WebKit/chromium/tests/DecimalTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/platform/Decimal.cpp

===================================================================

--- Source/WebCore/platform/Decimal.cpp (revision 122851)

+++ Source/WebCore/platform/Decimal.cpp (working copy)

@@ -628,7 +628,7 @@

const int numberOfDigits = countDigits(result);

const int numberOfDropDigits = -exponent();

if (numberOfDigits < numberOfDropDigits)

- return zero(Positive);

+ return isPositive() ? Decimal(1) : zero(Positive);

result = scaleDown(result, numberOfDropDigits - 1);

if (sign() == Positive && result % 10 > 0)

@@ -670,7 +670,7 @@

const int numberOfDigits = countDigits(result);

const int numberOfDropDigits = -exponent();

if (numberOfDigits < numberOfDropDigits)

- return zero(Positive);

+ return isPositive() ? zero(Positive) : Decimal(-1);

result = scaleDown(result, numberOfDropDigits - 1);

if (isNegative() && result % 10 > 0)