Issue 10786028: Record 'implements' keyword for class declaration nodes.

Issue 10786028: Record 'implements' keyword for class declaration nodes. (Closed)

Created:
8 years, 5 months ago by Roman

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Record 'implements' keyword for class declaration nodes. Do not record 'implements' or 'extends' in NodeList of implemented interfaces. Committed: https://code.google.com/p/dart/source/detail?r=10042

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
M	lib/compiler/implementation/scanner/listener.dart	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/scanner/parser.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Roman

https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart#newcode923 lib/compiler/implementation/scanner/listener.dart:923: NodeList supertypes = makeNodeList(supertypeCount, null, null, ','); Some explanation. ...

8 years, 4 months ago (2012-07-30 15:06:11 UTC) #3

Anton Muhin

https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart#newcode898 lib/compiler/implementation/scanner/listener.dart:898: Token extendsKeyword, Token implementsKeyword, where do you store now ...

8 years, 4 months ago (2012-07-30 15:35:50 UTC) #4

Roman

https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart#newcode898 lib/compiler/implementation/scanner/listener.dart:898: Token extendsKeyword, Token implementsKeyword, On 2012/07/30 15:35:50, Anton Mukhin ...

8 years, 4 months ago (2012-07-30 16:17:55 UTC) #5

Roman

https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): https://chromiumcodereview.appspot.com/10786028/diff/3001/lib/compiler/implementation/scanner/listener.dart#newcode898 lib/compiler/implementation/scanner/listener.dart:898: Token extendsKeyword, Token implementsKeyword, On 2012/07/30 16:17:55, Roman wrote: ...

8 years, 4 months ago (2012-07-30 16:19:26 UTC) #6

ahe

8 years, 4 months ago (2012-08-02 17:42:17 UTC) #8

I'm not happy with the part of this change that removes the keywords from the
NodeList.

As far as I'm concerned, there are three options:

1. Come up with a new concept that we use to record the extends, implements, and
default clauses.

2. Overload NodeList to record this information.

3. Do not record the keyword.

Option 3 is not on the table, sorry.

Initially, I chose option number 2, and I'm willing to discuss other
possibilities, but I think it would best if we restore the keywords in the node
lists for now and worry about refactoring the AST nodes later.

Expand Messages | Collapse Messages