Issue 10783017: Maintain the invariant that all HGraphBuilder::VisitFoo methods return void.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10783017: Maintain the invariant that all HGraphBuilder::VisitFoo methods return void. (Closed)

Created:
8 years, 5 months ago by Sven Panne

Modified:
8 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Maintain the invariant that all HGraphBuilder::VisitFoo methods return void. Additionally, this enables the use of a CHECK_ALIVE macro instead of copy-n-paste code at one place. This CL is part of a series of several yak-shaving CLs to prepare the inlining of JavaScript accessors. Committed: https://code.google.com/p/v8/source/detail?r=12093

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -11 lines)			Patch
	M	src/hydrogen.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	src/hydrogen.cc	View		2 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages