Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Side by Side Diff: src/hydrogen.h

Issue 10783017: Maintain the invariant that all HGraphBuilder::VisitFoo methods return void. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 958 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 // contexts. (It's allowed in all effect contexts and disallowed in all 969 // contexts. (It's allowed in all effect contexts and disallowed in all
970 // test contexts.) 970 // test contexts.)
971 void VisitForValue(Expression* expr, 971 void VisitForValue(Expression* expr,
972 ArgumentsAllowedFlag flag = ARGUMENTS_NOT_ALLOWED); 972 ArgumentsAllowedFlag flag = ARGUMENTS_NOT_ALLOWED);
973 void VisitForTypeOf(Expression* expr); 973 void VisitForTypeOf(Expression* expr);
974 void VisitForEffect(Expression* expr); 974 void VisitForEffect(Expression* expr);
975 void VisitForControl(Expression* expr, 975 void VisitForControl(Expression* expr,
976 HBasicBlock* true_block, 976 HBasicBlock* true_block,
977 HBasicBlock* false_block); 977 HBasicBlock* false_block);
978 978
979 // Visit an argument subexpression and emit a push to the outgoing 979 // Visit an argument subexpression and emit a push to the outgoing arguments.
980 // arguments. Returns the hydrogen value that was pushed. 980 void VisitArgument(Expression* expr);
981 HValue* VisitArgument(Expression* expr);
982 981
983 void VisitArgumentList(ZoneList<Expression*>* arguments); 982 void VisitArgumentList(ZoneList<Expression*>* arguments);
984 983
985 // Visit a list of expressions from left to right, each in a value context. 984 // Visit a list of expressions from left to right, each in a value context.
986 void VisitExpressions(ZoneList<Expression*>* exprs); 985 void VisitExpressions(ZoneList<Expression*>* exprs);
987 986
988 void AddPhi(HPhi* phi); 987 void AddPhi(HPhi* phi);
989 988
990 void PushAndAdd(HInstruction* instr); 989 void PushAndAdd(HInstruction* instr);
991 990
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
1451 const char* filename_; 1450 const char* filename_;
1452 HeapStringAllocator string_allocator_; 1451 HeapStringAllocator string_allocator_;
1453 StringStream trace_; 1452 StringStream trace_;
1454 int indent_; 1453 int indent_;
1455 }; 1454 };
1456 1455
1457 1456
1458 } } // namespace v8::internal 1457 } } // namespace v8::internal
1459 1458
1460 #endif // V8_HYDROGEN_H_ 1459 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698