Issue 10782038: Revert 147045 - Bring up a content settings icon for ungestured registerProtocolHandler call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10782038: Revert 147045 - Bring up a content settings icon for ungestured registerProtocolHandler call. (Closed)

Created:
8 years, 5 months ago by Scott Hess - ex-Googler

Modified:
8 years, 5 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 147045 - Bring up a content settings icon for ungestured registerProtocolHandler call. R=benwells@chromium.org BUG=122020 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144957 Review URL: https://chromiumcodereview.appspot.com/10584042 TBR=gbillock@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147079

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -2480 lines)			Patch
D	chrome/app/nibs/ContentProtocolHandlers.xib	View	1 chunk	+0 lines, -1978 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_default_provider.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/content_settings/content_settings_policy_provider.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/content_settings/content_settings_utils.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/content_settings/tab_specific_content_settings.h	View	3 chunks	+0 lines, -51 lines	0 comments	Download
M	chrome/browser/content_settings/tab_specific_content_settings.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	4 chunks	+5 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm	View	5 chunks	+19 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/content_settings/content_setting_bubble_model.cc	View	4 chunks	+14 lines, -179 lines	0 comments	Download
M	chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc	View	4 chunks	+0 lines, -148 lines	0 comments	Download
M	chrome/browser/ui/content_settings/content_setting_image_model.cc	View	3 chunks	+0 lines, -30 lines	0 comments	Download
M	chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/libgtk2ui/gtk2_ui.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/external_tab_container_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/content_settings_handler.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/content_settings_types.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/testing_profile.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/test/base/testing_profile.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/07/17 20:27:28, shess wrote:

lgtm

Expand Messages | Collapse Messages