Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 10782036: Merge 146016 - Fix a renderer crash when dragging quickly over tab contents. (Closed)

Created:
8 years, 5 months ago by tony
Modified:
8 years, 5 months ago
Reviewers:
tony
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Merge 146016 - Fix a renderer crash when dragging quickly over tab contents. We were expecting to receive GTK+ events in the following order: drag-motion drag-data-received drag-leave but in some cases, we don't get the drag-data-received event (e.g., if the user is moving the mouse quickly). If that happens, don't send a DragLeave event to the renderer since it doesn't think we're in a drag. BUG=129446 TEST=Open 2 chrome windows, quickly drag a file from the desktop over both windows. This should not crash. Review URL: https://chromiumcodereview.appspot.com/10704144 TBR=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/web_contents/web_drag_dest_gtk.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
tony
8 years, 5 months ago (2012-07-17 17:53:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698