Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 10704144: Fix a renderer crash when dragging quickly over tab contents. (Closed)

Created:
8 years, 5 months ago by tony
Modified:
8 years, 5 months ago
Reviewers:
jam, sky, dcheng
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng
Visibility:
Public.

Description

Fix a renderer crash when dragging quickly over tab contents. We were expecting to receive GTK+ events in the following order: drag-motion drag-data-received drag-leave but in some cases, we don't get the drag-data-received event (e.g., if the user is moving the mouse quickly). If that happens, don't send a DragLeave event to the renderer since it doesn't think we're in a drag. BUG=129446 TEST=Open 2 chrome windows, quickly drag a file from the desktop over both windows. This should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146016

Patch Set 1 #

Patch Set 2 : use data_requests_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/web_contents/web_drag_dest_gtk.cc View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tony
I don't like adding another bool just for this, but I can't think of a ...
8 years, 5 months ago (2012-07-10 22:47:33 UTC) #1
dcheng
Would checking data_requests_ > 0 be equivalent to the new bool?
8 years, 5 months ago (2012-07-10 22:49:00 UTC) #2
tony
On 2012/07/10 22:49:00, dcheng wrote: > Would checking data_requests_ > 0 be equivalent to the ...
8 years, 5 months ago (2012-07-10 22:56:19 UTC) #3
dcheng
lgtm
8 years, 5 months ago (2012-07-10 22:58:41 UTC) #4
tony
+OWNERS
8 years, 5 months ago (2012-07-10 23:01:01 UTC) #5
jam
lgtm
8 years, 5 months ago (2012-07-10 23:50:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10704144/4001
8 years, 5 months ago (2012-07-10 23:55:43 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 00:58:42 UTC) #8
Change committed as 146016

Powered by Google App Engine
This is Rietveld 408576698