Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 10782018: Merge 122529 - [chromium] Root invalidations for RTL pages need to be in the right space (Closed)

8 years, 5 months ago by enne (OOO)
8 years, 5 months ago
enne (OOO)
Base URL:


Merge 122529 - [chromium] Root invalidations for RTL pages need to be in the right space Reviewed by Kenneth Russell. Source/WebKit/chromium: The root layer has a translation on it when placed in the tree, so any invalidations on this layer likewise need to be adjusted. This adjustment is due to the fact that compositor layers all have the origin in the upper left corner of the layer, but this is not always the origin for graphics layers. Rather than making compositor layers have to deal with a potential offset, we change the transform when inserting the layer into the tree. Invalidations need to be similarly transformed from document space into compositor layer space. The need for this offset is due to the definition of the initial containing block. RTL pages (pages with dir=RTL on the body) start scrolled all the way to the right, and the origin is in the upper left hand corner of this initial viewport. Thus on RTL pages with horizontal overflow, the left of the document is in negative CSS space. * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::invalidateRect): LayoutTests: Add a test that demonstrates this problem. Before the code fix, the test shows just a red square because the invalidation for the style change repaints the wrong rect. * compositing/rtl/rtl-overflow-invalidation-expected.png: Added. * compositing/rtl/rtl-overflow-invalidation-expected.txt: Added. * compositing/rtl/rtl-overflow-invalidation.html: Added. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --2 lines) Patch
A + LayoutTests/compositing/rtl/rtl-overflow-invalidation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/rtl/rtl-overflow-invalidation-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/rtl/rtl-overflow-invalidation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebKit/chromium/src/NonCompositedContentHost.cpp View 1 chunk +3 lines, -1 line 0 comments Download


Total messages: 1 (0 generated)
enne (OOO)
8 years, 5 months ago (2012-07-16 19:49:08 UTC) #1


Powered by Google App Engine
This is Rietveld 408576698