Issue 107803004: Add base:: to string16 in extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107803004: Add base:: to string16 in extensions/. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add base:: to string16 in extensions/. R=yoz@chromium.org BUG=329295 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242211

Patch Set 1 : remove a using #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+191 lines, -178 lines)			Patch
M	extensions/browser/admin_policy.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	extensions/browser/admin_policy.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	extensions/browser/admin_policy_unittest.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	extensions/browser/extension_error.cc	View	4 chunks	+7 lines, -8 lines	0 comments	Download
M	extensions/browser/management_policy.h	View	5 chunks	+11 lines, -10 lines	0 comments	Download
M	extensions/browser/management_policy.cc	View	3 chunks	+10 lines, -9 lines	0 comments	Download
M	extensions/browser/management_policy_unittest.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	extensions/browser/test_management_policy.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	extensions/browser/test_management_policy.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	extensions/common/error_utils.h	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	extensions/common/error_utils.cc	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	extensions/common/extension.h	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	extensions/common/extension.cc	View	12 chunks	+15 lines, -15 lines	0 comments	Download
M	extensions/common/manifest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handler.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	extensions/common/manifest_handler.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	extensions/common/manifest_handler_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/common/manifest_handlers/background_info.h	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	extensions/common/manifest_handlers/background_info.cc	View	7 chunks	+8 lines, -7 lines	0 comments	Download
M	extensions/common/manifest_handlers/csp_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/csp_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/incognito_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/incognito_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/kiosk_mode_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/kiosk_mode_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/offline_enabled_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/offline_enabled_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/requirements_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/requirements_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/sandboxed_page_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/sandboxed_page_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_handlers/shared_module_info.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	extensions/common/manifest_handlers/shared_module_info.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	extensions/common/permissions/api_permission_set.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/permissions/api_permission_set.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/common/permissions/manifest_permission_set.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/permissions/manifest_permission_set.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	extensions/common/permissions/permission_message.h	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	extensions/common/permissions/permission_message.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	extensions/common/permissions/permission_message_provider.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	extensions/common/permissions/permissions_data.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/common/permissions/permissions_data.cc	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	extensions/common/permissions/permissions_data_unittest.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	extensions/common/value_builder.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	extensions/common/value_builder.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/107803004/20001

7 years ago (2013-12-20 20:09:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r242211 (presubmit successful).

Expand Messages | Collapse Messages