Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 107803004: Add base:: to string16 in extensions/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove a using Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | extensions/common/value_builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 extension, SocketPermissionRequest::UDP_SEND_TO, "example.com", 1900)); 146 extension, SocketPermissionRequest::UDP_SEND_TO, "example.com", 1900));
147 EXPECT_TRUE(CheckSocketPermission( 147 EXPECT_TRUE(CheckSocketPermission(
148 extension, 148 extension,
149 SocketPermissionRequest::UDP_SEND_TO, 149 SocketPermissionRequest::UDP_SEND_TO,
150 "239.255.255.250", 1900)); 150 "239.255.255.250", 1900));
151 } 151 }
152 152
153 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) { 153 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) {
154 scoped_refptr<Extension> extension; 154 scoped_refptr<Extension> extension;
155 extension = LoadManifest("permissions", "many-apis.json"); 155 extension = LoadManifest("permissions", "many-apis.json");
156 std::vector<string16> warnings = 156 std::vector<base::string16> warnings =
157 PermissionsData::GetPermissionMessageStrings(extension.get()); 157 PermissionsData::GetPermissionMessageStrings(extension.get());
158 ASSERT_EQ(6u, warnings.size()); 158 ASSERT_EQ(6u, warnings.size());
159 EXPECT_EQ("Access your data on api.flickr.com", 159 EXPECT_EQ("Access your data on api.flickr.com",
160 UTF16ToUTF8(warnings[0])); 160 UTF16ToUTF8(warnings[0]));
161 EXPECT_EQ("Read and modify your bookmarks", UTF16ToUTF8(warnings[1])); 161 EXPECT_EQ("Read and modify your bookmarks", UTF16ToUTF8(warnings[1]));
162 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2])); 162 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2]));
163 EXPECT_EQ("Read and modify your browsing history", UTF16ToUTF8(warnings[3])); 163 EXPECT_EQ("Read and modify your browsing history", UTF16ToUTF8(warnings[3]));
164 EXPECT_EQ("Access your tabs and browsing activity", UTF16ToUTF8(warnings[4])); 164 EXPECT_EQ("Access your tabs and browsing activity", UTF16ToUTF8(warnings[4]));
165 EXPECT_EQ("Manage your apps, extensions, and themes", 165 EXPECT_EQ("Manage your apps, extensions, and themes",
166 UTF16ToUTF8(warnings[5])); 166 UTF16ToUTF8(warnings[5]));
167 } 167 }
168 168
169 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) { 169 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) {
170 scoped_refptr<Extension> extension; 170 scoped_refptr<Extension> extension;
171 extension = LoadManifest("permissions", "more-than-3-hosts.json"); 171 extension = LoadManifest("permissions", "more-than-3-hosts.json");
172 std::vector<string16> warnings = 172 std::vector<base::string16> warnings =
173 PermissionsData::GetPermissionMessageStrings(extension.get()); 173 PermissionsData::GetPermissionMessageStrings(extension.get());
174 std::vector<string16> warnings_details = 174 std::vector<base::string16> warnings_details =
175 PermissionsData::GetPermissionMessageDetailsStrings(extension.get()); 175 PermissionsData::GetPermissionMessageDetailsStrings(extension.get());
176 ASSERT_EQ(1u, warnings.size()); 176 ASSERT_EQ(1u, warnings.size());
177 ASSERT_EQ(1u, warnings_details.size()); 177 ASSERT_EQ(1u, warnings_details.size());
178 EXPECT_EQ("Access your data on 5 websites", UTF16ToUTF8(warnings[0])); 178 EXPECT_EQ("Access your data on 5 websites", UTF16ToUTF8(warnings[0]));
179 EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com", 179 EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com",
180 UTF16ToUTF8(warnings_details[0])); 180 UTF16ToUTF8(warnings_details[0]));
181 } 181 }
182 182
183 TEST(ExtensionPermissionsTest, GetPermissionMessages_LocationApiPermission) { 183 TEST(ExtensionPermissionsTest, GetPermissionMessages_LocationApiPermission) {
184 scoped_refptr<Extension> extension; 184 scoped_refptr<Extension> extension;
185 extension = LoadManifest("permissions", 185 extension = LoadManifest("permissions",
186 "location-api.json", 186 "location-api.json",
187 Manifest::COMPONENT, 187 Manifest::COMPONENT,
188 Extension::NO_FLAGS); 188 Extension::NO_FLAGS);
189 std::vector<string16> warnings = 189 std::vector<base::string16> warnings =
190 PermissionsData::GetPermissionMessageStrings(extension.get()); 190 PermissionsData::GetPermissionMessageStrings(extension.get());
191 ASSERT_EQ(1u, warnings.size()); 191 ASSERT_EQ(1u, warnings.size());
192 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[0])); 192 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[0]));
193 } 193 }
194 194
195 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHosts) { 195 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHosts) {
196 scoped_refptr<Extension> extension; 196 scoped_refptr<Extension> extension;
197 extension = LoadManifest("permissions", "many-hosts.json"); 197 extension = LoadManifest("permissions", "many-hosts.json");
198 std::vector<string16> warnings = 198 std::vector<base::string16> warnings =
199 PermissionsData::GetPermissionMessageStrings(extension.get()); 199 PermissionsData::GetPermissionMessageStrings(extension.get());
200 ASSERT_EQ(1u, warnings.size()); 200 ASSERT_EQ(1u, warnings.size());
201 EXPECT_EQ("Access your data on encrypted.google.com and www.google.com", 201 EXPECT_EQ("Access your data on encrypted.google.com and www.google.com",
202 UTF16ToUTF8(warnings[0])); 202 UTF16ToUTF8(warnings[0]));
203 } 203 }
204 204
205 TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) { 205 TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) {
206 scoped_refptr<Extension> extension; 206 scoped_refptr<Extension> extension;
207 extension = LoadManifest("permissions", "plugins.json"); 207 extension = LoadManifest("permissions", "plugins.json");
208 std::vector<string16> warnings = 208 std::vector<base::string16> warnings =
209 PermissionsData::GetPermissionMessageStrings(extension.get()); 209 PermissionsData::GetPermissionMessageStrings(extension.get());
210 // We don't parse the plugins key on Chrome OS, so it should not ask for any 210 // We don't parse the plugins key on Chrome OS, so it should not ask for any
211 // permissions. 211 // permissions.
212 #if defined(OS_CHROMEOS) 212 #if defined(OS_CHROMEOS)
213 ASSERT_EQ(0u, warnings.size()); 213 ASSERT_EQ(0u, warnings.size());
214 #else 214 #else
215 ASSERT_EQ(1u, warnings.size()); 215 ASSERT_EQ(1u, warnings.size());
216 EXPECT_EQ("Access all data on your computer and the websites you visit", 216 EXPECT_EQ("Access all data on your computer and the websites you visit",
217 UTF16ToUTF8(warnings[0])); 217 UTF16ToUTF8(warnings[0]));
218 #endif 218 #endif
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 PermissionsData::ClearTabSpecificPermissions(extension.get(), 1); 611 PermissionsData::ClearTabSpecificPermissions(extension.get(), 1);
612 EXPECT_FALSE(PermissionsData::GetTabSpecificPermissions(extension.get(), 1) 612 EXPECT_FALSE(PermissionsData::GetTabSpecificPermissions(extension.get(), 1)
613 .get()); 613 .get());
614 614
615 EXPECT_TRUE(AllowedExclusivelyOnTab(extension.get(), no_urls, 0)); 615 EXPECT_TRUE(AllowedExclusivelyOnTab(extension.get(), no_urls, 0));
616 EXPECT_TRUE(AllowedExclusivelyOnTab(extension.get(), no_urls, 1)); 616 EXPECT_TRUE(AllowedExclusivelyOnTab(extension.get(), no_urls, 1));
617 EXPECT_TRUE(AllowedExclusivelyOnTab(extension.get(), no_urls, 2)); 617 EXPECT_TRUE(AllowedExclusivelyOnTab(extension.get(), no_urls, 2));
618 } 618 }
619 619
620 } // namespace extensions 620 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | extensions/common/value_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698