Issue 10780019: PPAPI (Flash): Properly honor Pepper url requests with custom user agents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10780019: PPAPI (Flash): Properly honor Pepper url requests with custom user agents. (Closed)

Created:
8 years, 5 months ago by viettrungluu

Modified:
8 years, 5 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI (Flash): Properly honor Pepper url requests with custom user agents. BUG=134615 TEST=With suitably recent Flapper: http://10tv.nana10.co.il/ streams properly (see bug for appropriate things to click). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147060

Patch Set 1 #

Patch Set 2 : fix resource_dispatcher_unittest.cc #

Patch Set 3 : d'oh #

Total comments: 1

Patch Set 4 : got rid of unneeded WebKit:: #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -10 lines)			Patch
M	content/common/request_extra_data.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/request_extra_data.cc	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/common/resource_dispatcher_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
M	webkit/glue/weburlrequest_extradata_impl.h	View		2 chunks	+12 lines, -1 line	0 comments	Download
M	webkit/glue/weburlrequest_extradata_impl.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_request_info_impl.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

Hrm, this feels kind of hacky; suggestions for making it less hacky welcome.

8 years, 5 months ago (2012-07-16 19:24:12 UTC) #1

darin (slow to review)

8 years, 5 months ago (2012-07-17 18:24:06 UTC) #4

LGTM

https://chromiumcodereview.appspot.com/10780019/diff/7002/content/renderer/re...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/10780019/diff/7002/content/renderer/re...
content/renderer/render_view_impl.cc:3305: WebKit::WebString custom_user_agent;
nit: no need for WebKit:: prefix here.  see using declaration at top of file.

Expand Messages | Collapse Messages