Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: webkit/plugins/ppapi/ppb_url_request_info_impl.cc

Issue 10780019: PPAPI (Flash): Properly honor Pepper url requests with custom user agents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: got rid of unneeded WebKit:: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/weburlrequest_extradata_impl.cc ('k') | webkit/support/webkit_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_url_request_info_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_url_request_info_impl.cc b/webkit/plugins/ppapi/ppb_url_request_info_impl.cc
index 9bc99bf00a9f30dd6842b9168e75bfeb27935d69..da379cb20abc0e8d80b72dfc8134a839647beab8 100644
--- a/webkit/plugins/ppapi/ppb_url_request_info_impl.cc
+++ b/webkit/plugins/ppapi/ppb_url_request_info_impl.cc
@@ -18,6 +18,7 @@
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURL.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLRequest.h"
#include "webkit/glue/webkit_glue.h"
+#include "webkit/glue/weburlrequest_extradata_impl.h"
#include "webkit/plugins/ppapi/common.h"
#include "webkit/plugins/ppapi/plugin_module.h"
#include "webkit/plugins/ppapi/ppb_file_ref_impl.h"
@@ -121,10 +122,9 @@ bool PPB_URLRequestInfo_Impl::ToWebURLRequest(WebFrame* frame,
}
if (data().has_custom_user_agent) {
- // TODO(viettrungluu): If |custom_user_agent| is empty, we're supposed to
- // arrange for User-Agent to be omitted; this probably won't do that.
- dest->addHTTPHeaderField(WebString::fromUTF8("User-Agent"),
- WebString::fromUTF8(data().custom_user_agent));
+ dest->setExtraData(new webkit_glue::WebURLRequestExtraDataImpl(
+ WebKit::WebReferrerPolicyDefault, // Ignored.
+ WebString::fromUTF8(data().custom_user_agent)));
}
return true;
« no previous file with comments | « webkit/glue/weburlrequest_extradata_impl.cc ('k') | webkit/support/webkit_support.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698