Fix focus notification for Flash fullscreen.

Fix focus notification for Flash fullscreen.

This CL also changes the Windows code to dismiss Flash fullscreen when it loses focus. This matches the behavior of NPAPI Flash and Linux Pepper Flash.

BUG=137264
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147283

[yzshen1, 2012-07-16 22:53:03]

Hi, Brett and Kazuhiro.

Would you please take a look?

Brett: everything.
Kazuhiro: I think you added PluginFocusChanged notification in SetWebKitFocus. I
think we should do the same for other places where we change focus. Please let
me know if there is any reason we shouldn't do so.

Thanks!

[brettw, 2012-07-17 20:06:14]

http://codereview.chromium.org/10779023/diff/1/webkit/plugins/ppapi/ppapi_plu...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/10779023/diff/1/webkit/plugins/ppapi/ppapi_plu...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1355: if (PluginHasFocus() !=
old_plugin_focus)
This seems wrong. The old_plugin_focus value was just set from PluginHasFocus
above and I don't think it could have changed in the meantime.

[yzshen1, 2012-07-18 01:17:58]

http://codereview.chromium.org/10779023/diff/1/webkit/plugins/ppapi/ppapi_plu...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/10779023/diff/1/webkit/plugins/ppapi/ppapi_plu...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1355: if (PluginHasFocus() !=
old_plugin_focus)
PluginHasFocus() was changed and it is now determined by flash_fullscreen_ and
has_*_focus_, so it is possible that PluginHasFocus() is different from
old_plugin_focus after line 1354.

On 2012/07/17 20:06:14, brettw wrote:
> This seems wrong. The old_plugin_focus value was just set from PluginHasFocus
> above and I don't think it could have changed in the meantime.

[kinaba, 2012-07-18 01:21:40]

LGTM for code around PluginFocusChanged. Thanks!

[brettw, 2012-07-18 17:56:52]

LGTM

[commit-bot: I haz the power, 2012-07-18 17:56:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/10779023/1

[commit-bot: I haz the power, 2012-07-18 19:06:38]

Change committed as 147283