Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: utils/apidoc/html_diff.dart

Issue 10779010: Parameters with function types supported + Added features in mirrors implementation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/apidoc/html_diff.dart
diff --git a/utils/apidoc/html_diff.dart b/utils/apidoc/html_diff.dart
index 8d55542491cc7bed111a6d402cffa07eed7d1a00..03e5bd696ae452ddaad9f4458b0e9d7287268e0f 100644
--- a/utils/apidoc/html_diff.dart
+++ b/utils/apidoc/html_diff.dart
@@ -46,8 +46,11 @@ class HtmlDiff {
final Map<MemberMirror, Set<MemberMirror>> domToHtml;
/** A map from `dart:html` members to corresponding
- * `dart:dom_deprecated` members. */
- final Map<MemberMirror, Set<MemberMirror>> htmlToDom;
+ * `dart:dom_deprecated` members.
+ * TODO(johnniwinther): We use qualified names as keys, since mirrors
+ * (currently) are not equal between different mirror systems.
+ */
+ final Map<String, Set<MemberMirror>> htmlToDom;
/** A map from `dart:dom_deprecated` types to corresponding
* `dart:html` types.
@@ -88,7 +91,7 @@ class HtmlDiff {
HtmlDiff([bool printWarnings = false]) :
_printWarnings = printWarnings,
domToHtml = new Map<MemberMirror, Set<MemberMirror>>(),
- htmlToDom = new Map<MemberMirror, Set<MemberMirror>>(),
+ htmlToDom = new Map<String, Set<MemberMirror>>(),
domTypesToHtml = new Map<String, Set<InterfaceMirror>>(),
htmlTypesToDom = new Map<String, Set<InterfaceMirror>>(),
comments = new CommentMap();
@@ -142,7 +145,9 @@ class HtmlDiff {
}
if (htmlMember == null) return;
- if (!domMembers.isEmpty()) htmlToDom[htmlMember] = domMembers;
+ if (!domMembers.isEmpty()) {
+ htmlToDom[htmlMember.qualifiedName()] = domMembers;
+ }
domMembers.forEach((m) =>
domToHtml.putIfAbsent(m, () => new Set()).add(htmlMember));
}
« lib/compiler/implementation/elements/elements.dart ('K') | « utils/apidoc/apidoc.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698