Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: utils/apidoc/apidoc.dart

Issue 10779010: Parameters with function types supported + Added features in mirrors implementation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/apidoc/apidoc.dart
diff --git a/utils/apidoc/apidoc.dart b/utils/apidoc/apidoc.dart
index 38bd7f17836bc2a3abf94d69386f993bd683f8e8..c7821a3a28f2d2cb89d103762566454dff4b2dc6 100644
--- a/utils/apidoc/apidoc.dart
+++ b/utils/apidoc/apidoc.dart
@@ -488,7 +488,7 @@ class Apidoc extends doc.Dartdoc {
if (library.simpleName() == 'html') {
// If it's an HTML type, try to map it to a base DOM type so we can find
// the MDN docs.
- final domMembers = _diff.htmlToDom[member];
+ final domMembers = _diff.htmlToDom[member.qualifiedName()];
// Couldn't find a DOM type.
if ((domMembers == null) || (domMembers.length != 1)) return null;
@@ -508,9 +508,6 @@ class Apidoc extends doc.Dartdoc {
final mdnType = mdn[member.surroundingDeclaration().simpleName()];
if (mdnType == null) return null;
var nameToFind = member.simpleName();
- if (nameToFind.startsWith(GET_PREFIX)) {
- nameToFind = nameToFind.substring(GET_PREFIX.length);
- }
var mdnMember = null;
for (final candidateMember in mdnType['members']) {
if (candidateMember['name'] == nameToFind) {

Powered by Google App Engine
This is Rietveld 408576698