Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 10779005: Reorder CookieIsolation so that the intentional Crash occurs after tab ExecuteJavaScript. (Closed)

Created:
8 years, 5 months ago by awong
Modified:
8 years, 5 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Reorder CookieIsolation so that the intentional Crash occurs after tab ExecuteJavaScript. This is a stopgap that avoids letting ExecuteJavaScript() hang in the situation that Reload() causes a tab to crash. Putting this in for now to make try-bot cycle time better while the underlying issue is investigated. BUG=137313 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M chrome/browser/extensions/isolated_app_browsertest.cc View 2 chunks +29 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
awong
crashed renderer? what crashed renderer? :P
8 years, 5 months ago (2012-07-13 22:32:35 UTC) #1
Charlie Reis
LGTM. Thanks for getting a bug filed for the underlying problem.
8 years, 5 months ago (2012-07-13 22:37:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/10779005/1
8 years, 5 months ago (2012-07-13 22:38:13 UTC) #3
nasko
lgtm
8 years, 5 months ago (2012-07-13 22:42:24 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-13 23:42:52 UTC) #5
Change committed as 146685

Powered by Google App Engine
This is Rietveld 408576698