Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 10778019: Remove gfx_unittests target in favor of ui_unittests (Closed)

Created:
8 years, 5 months ago by dhollowa
Modified:
8 years, 4 months ago
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Remove gfx_unittests target in favor of ui_unittests Removes the gfx_unittests target from various .gyp files in favor of ui_unittests. This can be landed once the master builders are restarted with the change: https://chromiumcodereview.appspot.com/10778013 TEST=None BUG=133864 R=tony@chromium.org, hbono@chromium.org, petermayo@chromium.org TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149633

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -55 lines) Patch
M build/all.gyp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M tools/heapcheck/chrome_tests.py View 1 2 chunks +0 lines, -8 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 2 chunks +0 lines, -8 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 1 chunk +2 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dhollowa
8 years, 5 months ago (2012-07-16 19:11:13 UTC) #1
tony
LGTM, thanks!
8 years, 5 months ago (2012-07-16 19:13:48 UTC) #2
Hironori Bono
LGTM2. Thanks for removing my band-aid fix. Regards, Hironori Bono
8 years, 5 months ago (2012-07-17 00:22:07 UTC) #3
Peter Mayo
LGTM too, thanks for the notice, but I'm no gyp expert.
8 years, 5 months ago (2012-07-17 00:25:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778019/1
8 years, 4 months ago (2012-08-01 21:01:40 UTC) #5
commit-bot: I haz the power
Failed to apply patch for build/all.gyp: While running patch -p1 --forward --force; patching file build/all.gyp ...
8 years, 4 months ago (2012-08-01 21:01:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778019/10001
8 years, 4 months ago (2012-08-01 21:14:43 UTC) #7
commit-bot: I haz the power
Presubmit check for 10778019-10001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-01 21:14:53 UTC) #8
dhollowa
+ben -> owner of ui/ +thestig -> owner of tools/valgrind/
8 years, 4 months ago (2012-08-01 21:22:05 UTC) #9
Timur Iskhodzhanov
tools/valgrind part LGTM
8 years, 4 months ago (2012-08-02 08:03:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778019/10001
8 years, 4 months ago (2012-08-02 14:41:34 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 15:47:24 UTC) #12
Change committed as 149633

Powered by Google App Engine
This is Rietveld 408576698