Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 10778013: Run ui_unittests instead of gfx_unittests on the waterfall (Closed)

Created:
8 years, 5 months ago by dhollowa
Modified:
8 years, 4 months ago
Reviewers:
cmp, tony, Peter Mayo
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Run ui_unittests instead of gfx_unittests on the waterfall Removes remaining references to the gfx_unittests targets on the masters. This target has been replaced by the ui_unittests target. TEST=None BUG=133864 R=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149509

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M scripts/master/factory/chromium_factory.py View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
dhollowa
Looks like all the slaves have been switched over to ui_unittests, so this removes gfx_unittests ...
8 years, 5 months ago (2012-07-16 17:27:14 UTC) #1
tony
LGTM, thanks!
8 years, 5 months ago (2012-07-16 17:30:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778013/1
8 years, 5 months ago (2012-07-16 17:39:03 UTC) #3
commit-bot: I haz the power
Presubmit check for 10778013-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-16 17:40:16 UTC) #4
dhollowa
Peter, PTAL. Thanks.
8 years, 5 months ago (2012-07-16 18:56:25 UTC) #5
dhollowa
This CL is blocked on https://chromereviews.googleplex.com/4614040/. Waiting for that to land before landing this.
8 years, 5 months ago (2012-07-17 14:51:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778013/1
8 years, 4 months ago (2012-08-01 20:59:44 UTC) #7
commit-bot: I haz the power
Failed to apply patch for build/scripts/master/factory/chromium_factory.py: While running patch -p0 --forward --force; patching file build/scripts/master/factory/chromium_factory.py ...
8 years, 4 months ago (2012-08-01 20:59:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778013/9001
8 years, 4 months ago (2012-08-01 21:19:35 UTC) #9
commit-bot: I haz the power
Presubmit check for 10778013-9001 failed and returned exit status -2001. The presubmit check was hung. ...
8 years, 4 months ago (2012-08-01 21:34:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778013/9001
8 years, 4 months ago (2012-08-01 21:57:09 UTC) #11
commit-bot: I haz the power
Presubmit check for 10778013-9001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-01 21:58:24 UTC) #12
cmp
lgtm
8 years, 4 months ago (2012-08-01 22:05:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10778013/9001
8 years, 4 months ago (2012-08-01 22:05:44 UTC) #14
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 22:07:08 UTC) #15
Change committed as 149509

Powered by Google App Engine
This is Rietveld 408576698