Issue 10778011: Remove LookupTransitionOrDescriptor altogether.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10778011: Remove LookupTransitionOrDescriptor altogether. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 5 months ago

Reviewers:
Sven Panne, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove LookupTransitionOrDescriptor altogether. Committed: https://code.google.com/p/v8/source/detail?r=12100

Patch Set 1 : u #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -44 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	5 chunks	+9 lines, -18 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	3 chunks	+4 lines, -20 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 5 months ago (2012-07-17 05:54:41 UTC) #3

http://codereview.chromium.org/10778011/diff/2001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/10778011/diff/2001/src/objects.cc#newcode12533
src/objects.cc:12533: MaybeObject* maybe_fields =
Even if it is too late, I'd like to comment on this kind of change: I strongly
dislike removing these scopes, because this actively destroys very useful
information. Using a tiny scope makes it crystal-clear what is going on (namely
a bind operation in the Maybe monad) and that the MaybeObject* is only used
locally. I wouldn't argue much if all our functions were in the 10-lines range,
but given our usual monstrous code chunks, the scope really has a value when
trying to understand/refactor things.

We should make reading our code *easier*, not harder...

Expand Messages | Collapse Messages