Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 10778011: Remove LookupTransitionOrDescriptor altogether. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: u Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2561 matching lines...) Expand 10 before | Expand all | Expand 10 after
2572 } 2572 }
2573 } 2573 }
2574 2574
2575 2575
2576 void LCodeGen::EmitLoadFieldOrConstantFunction(Register result, 2576 void LCodeGen::EmitLoadFieldOrConstantFunction(Register result,
2577 Register object, 2577 Register object,
2578 Handle<Map> type, 2578 Handle<Map> type,
2579 Handle<String> name, 2579 Handle<String> name,
2580 LEnvironment* env) { 2580 LEnvironment* env) {
2581 LookupResult lookup(isolate()); 2581 LookupResult lookup(isolate());
2582 type->LookupTransitionOrDescriptor(NULL, *name, &lookup); 2582 type->LookupDescriptor(NULL, *name, &lookup);
2583 ASSERT(lookup.IsFound() || lookup.IsCacheable()); 2583 ASSERT(lookup.IsFound() || lookup.IsCacheable());
2584 if (lookup.IsField()) { 2584 if (lookup.IsField()) {
2585 int index = lookup.GetLocalFieldIndexFromMap(*type); 2585 int index = lookup.GetLocalFieldIndexFromMap(*type);
2586 int offset = index * kPointerSize; 2586 int offset = index * kPointerSize;
2587 if (index < 0) { 2587 if (index < 0) {
2588 // Negative property indices are in-object properties, indexed 2588 // Negative property indices are in-object properties, indexed
2589 // from the end of the fixed part of the object. 2589 // from the end of the fixed part of the object.
2590 __ ldr(result, FieldMemOperand(object, offset + type->instance_size())); 2590 __ ldr(result, FieldMemOperand(object, offset + type->instance_size()));
2591 } else { 2591 } else {
2592 // Non-negative property indices are in the properties array. 2592 // Non-negative property indices are in the properties array.
(...skipping 2808 matching lines...) Expand 10 before | Expand all | Expand 10 after
5401 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 5401 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
5402 __ ldr(result, FieldMemOperand(scratch, 5402 __ ldr(result, FieldMemOperand(scratch,
5403 FixedArray::kHeaderSize - kPointerSize)); 5403 FixedArray::kHeaderSize - kPointerSize));
5404 __ bind(&done); 5404 __ bind(&done);
5405 } 5405 }
5406 5406
5407 5407
5408 #undef __ 5408 #undef __
5409 5409
5410 } } // namespace v8::internal 5410 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698