Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2092)

Unified Diff: annotated_steps.py

Issue 1077563002: Use append_logs argument on all runs but the first (Closed) Base URL: git@github.com:dart-lang/package-bots.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: annotated_steps.py
diff --git a/annotated_steps.py b/annotated_steps.py
index 92579ff5afbe2127e7a7d560fbcd78baee3482a0..3b4897c5b952c190eba08a667b527548ffdc7826 100755
--- a/annotated_steps.py
+++ b/annotated_steps.py
@@ -304,6 +304,14 @@ JS_RUNTIMES = {
'mac': ['safari'],
}
+is_first_test_run = True
+def LogsArgument():
+ global is_first_test_run
+ if is_first_test_run:
+ is_first_test_run = False
+ return []
+ return ['--append_logs']
+
def RunPackageTesting(bot_info, package_path, folder='test'):
package_name = os.path.basename(package_path)
if package_name == '':
@@ -331,16 +339,19 @@ def RunPackageTesting(bot_info, package_path, folder='test'):
with BuildStep('Test vm release mode%s' % suffix, swallow_error=True):
args = [sys.executable, 'tools/test.py',
'-mrelease', '-rvm', '-cnone'] + standard_args
+ args.extend(LogsArgument())
RunProcess(args)
with BuildStep('Test analyzer%s' % suffix, swallow_error=True):
args = [sys.executable, 'tools/test.py',
'-mrelease', '-rnone', '-cdart2analyzer'] + standard_args
+ args.extend(LogsArgument())
RunProcess(args)
if bot_info.system != 'windows':
with BuildStep('Test dartium%s' % suffix, swallow_error=True):
test_args = [sys.executable, 'tools/test.py',
'-mrelease', '-rdartium', '-cnone', '-j4']
args = xvfb_args + test_args + standard_args
+ args.extend(LogsArgument())
RunProcess(args)
for runtime in JS_RUNTIMES[system]:
@@ -349,6 +360,7 @@ def RunPackageTesting(bot_info, package_path, folder='test'):
'-mrelease', '-r%s' % runtime, '-cdart2js', '-j4',
'--dart2js-batch']
args = xvfb_args + test_args + standard_args
+ args.extend(LogsArgument())
RunProcess(args)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698