Use append_logs argument on all runs but the first

annotated_steps.py

 #!/usr/bin/python
 
 # Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import imp
 import os
 import re
 import shutil
@@ skipping 286 matching lines @@
     shutil.copy(dart_controller, test_controller)
   else:
     print "No unittest to patch, do you even have tests"
 
 JS_RUNTIMES = {
   'windows': ['ff', 'chrome', 'ie10'],
   'linux': ['d8', 'jsshell', 'ff', 'chrome'],
   'mac': ['safari'],
 }
 
+is_first_test_run = True
+def LogsArgument():
+  global is_first_test_run
+  if is_first_test_run:
+    is_first_test_run = False
+    return []
+  return ['--append_logs']
+
 def RunPackageTesting(bot_info, package_path, folder='test'):
   package_name = os.path.basename(package_path)
   if package_name == '':
     # when package_path had a trailing slash
     package_name = os.path.basename(os.path.dirname(package_path))
   package_root = os.path.join(package_path, folder, 'packages')
 
   # Note: we use package_name/package_name/folder and not package_name/folder on
   # purpose. The first package_name denotes the suite, the second is part of the
   # path we want to match. Without the second package_name, we may match tests
   # that contain "folder" further down. So if folder is "test",
   # "package_name/test" matches "package_name/build/test", but
   # "package_name/package_name/test" does not.
   standard_args = ['--suite-dir=%s' % package_path,
                    '--use-sdk', '--report', '--progress=buildbot',
                    '--clear_browser_cache',
                    '--package-root=%s' % package_root,
                    '--write-debug-log', '-v',
                    '--time',
                    '%s/%s/%s/' % (package_name, package_name, folder)]
   system = bot_info.system
   xvfb_command = ['xvfb-run', '-a', '--server-args=-screen 0 1024x768x24']
   xvfb_args =  xvfb_command if system == 'linux' else []
   suffix = ' under build' if folder == 'build/test' else ''
   with BuildStep('Test vm release mode%s' % suffix, swallow_error=True):
     args = [sys.executable, 'tools/test.py',
             '-mrelease', '-rvm', '-cnone'] + standard_args
+    args.extend(LogsArgument())
     RunProcess(args)
   with BuildStep('Test analyzer%s' % suffix, swallow_error=True):
     args = [sys.executable, 'tools/test.py',
             '-mrelease', '-rnone', '-cdart2analyzer'] + standard_args
+    args.extend(LogsArgument())
     RunProcess(args)
   if bot_info.system != 'windows':
     with BuildStep('Test dartium%s' % suffix, swallow_error=True):
       test_args = [sys.executable, 'tools/test.py',
                    '-mrelease', '-rdartium', '-cnone', '-j4']
       args = xvfb_args + test_args + standard_args
+      args.extend(LogsArgument())
       RunProcess(args)
 
   for runtime in JS_RUNTIMES[system]:
     with BuildStep('dart2js-%s%s' % (runtime, suffix), swallow_error=True):
       test_args = [sys.executable, 'tools/test.py',
                    '-mrelease', '-r%s' % runtime, '-cdart2js', '-j4',
                    '--dart2js-batch']
       args = xvfb_args + test_args + standard_args
+      args.extend(LogsArgument())
       RunProcess(args)
 
 
 def RunHooks(hooks, section_name):
   for name, command in hooks.iteritems():
     with BuildStep('%s: %s' % (section_name, name), swallow_error=True):
       RunProcess(command, shell=True)
 
 def RunPrePubUpgradeHooks(test_config):
   RunHooks(test_config.get_pre_pub_upgrade_hooks(), "Pre pub upgrade hooks")
@@ skipping 26 matching lines @@
   RunPrePubBuildHooks(test_config)
   RunPubBuild(bot_info, copy_path, 'web')
   RunPubBuild(bot_info, copy_path, 'test', 'debug')
   RunPostPubBuildHooks(test_config)
   FixupTestControllerJS(copy_path)
 
   RunPreTestHooks(test_config)
   RunPackageTesting(bot_info, copy_path, 'test')
   RunPackageTesting(bot_info, copy_path, 'build/test')
   RunPostTestHooks(test_config)