Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: chrome/browser/metrics/variations_service.h

Issue 10764005: Added tests for storing and loading seed data to and from prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more merge conflicts Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/variations_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations_service.h
diff --git a/chrome/browser/metrics/variations_service.h b/chrome/browser/metrics/variations_service.h
index c4665aab9fa4b8f04cb7b10c3b072f0a27fe55a5..af40833a8ec91d64ce54d9746ba745045ec3a39c 100644
--- a/chrome/browser/metrics/variations_service.h
+++ b/chrome/browser/metrics/variations_service.h
@@ -58,13 +58,15 @@ class VariationsService : public net::URLFetcherDelegate {
FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, CheckStudyVersionWildcards);
FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, CheckStudyStartDate);
FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, IsStudyExpired);
+ FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, LoadSeed);
+ FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, StoreSeed);
FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, ValidateStudy);
// Store the given seed data to the given local prefs. Note that |seed_data|
// is assumed to be the raw serialized protobuf data stored in a string. It
// will be Base64Encoded for storage. If the string is invalid or the encoding
- // fails, the |local_prefs| is left as is.
- void StoreSeedData(const std::string& seed_data,
+ // fails, the |local_prefs| is left as is and the function returns false.
+ bool StoreSeedData(const std::string& seed_data,
const base::Time& seed_date,
PrefService* local_prefs);
« no previous file with comments | « no previous file | chrome/browser/metrics/variations_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698